| Message ID | 20180216174034.15936-2-enric.balletbo@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,v5,1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle. | expand |
On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote: > Hardware needs a delay between setting an initial (non-zero) PWM and > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > this delay in milli seconds. Hardware also needs a delay between disabing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Acked-by: Pavel Machek <pavel@ucw.cz> > --- > Based on the original Huang Lin <hl@rock-chips.com> work. > > Changes since v4: > - Rebase on top of mainline. > Changes since v3: > - Replace us for ms. > - Add Acked-by: Pavel Machek <pavel@ucw.cz> > Changes since v2: > - Use separate properties (Rob Herring) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > 1 file changed, 6 insertions(+) Looks like this still needs an Ack. Also, you didn't supply a 0th (cover-letter) patch, so I have no idea of patch history or your future intentions. Are there build-time dependencies between them or can each patch be merged via their respective trees without the fear of merge/build failure?
Hi Lee, Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones: > On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote: > > > Hardware needs a delay between setting an initial (non-zero) PWM and > > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > > this delay in milli seconds. Hardware also needs a delay between disabing > > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > > is this delay in milli seconds. > > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Acked-by: Pavel Machek <pavel@ucw.cz> > > --- > > Based on the original Huang Lin <hl@rock-chips.com> work. > > > > Changes since v4: > > - Rebase on top of mainline. > > Changes since v3: > > - Replace us for ms. > > - Add Acked-by: Pavel Machek <pavel@ucw.cz> > > Changes since v2: > > - Use separate properties (Rob Herring) > > Changes since v1: > > - As suggested by Daniel Thompson > > - Do not assume power-on delay and power-off delay will be the same > > > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Looks like this still needs an Ack. > > Also, you didn't supply a 0th (cover-letter) patch, so I have no idea > of patch history or your future intentions. > > Are there build-time dependencies between them or can each patch be > merged via their respective trees without the fear of merge/build > failure? When looking at the patches, there do not seem to be any build-time dependencies between the patch 1-3 (backlight) and 4+5 devicetree, so after Rob hopefully has time to look at the binding change, I'd suspect you take the code changes and I'll take the dts changes. Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 19 Feb 2018, Heiko Stuebner wrote: > Am Montag, 19. Februar 2018, 10:22:47 CET schrieb Lee Jones: > > On Fri, 16 Feb 2018, Enric Balletbo i Serra wrote: > > > > > Hardware needs a delay between setting an initial (non-zero) PWM and > > > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > > > this delay in milli seconds. Hardware also needs a delay between disabing > > > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > > > is this delay in milli seconds. > > > > > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > > Acked-by: Pavel Machek <pavel@ucw.cz> > > > --- > > > Based on the original Huang Lin <hl@rock-chips.com> work. > > > > > > Changes since v4: > > > - Rebase on top of mainline. > > > Changes since v3: > > > - Replace us for ms. > > > - Add Acked-by: Pavel Machek <pavel@ucw.cz> > > > Changes since v2: > > > - Use separate properties (Rob Herring) > > > Changes since v1: > > > - As suggested by Daniel Thompson > > > - Do not assume power-on delay and power-off delay will be the same > > > > > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > Looks like this still needs an Ack. > > > > Also, you didn't supply a 0th (cover-letter) patch, so I have no idea > > of patch history or your future intentions. > > > > Are there build-time dependencies between them or can each patch be > > merged via their respective trees without the fear of merge/build > > failure? > > When looking at the patches, there do not seem to be any build-time > dependencies between the patch 1-3 (backlight) and 4+5 devicetree, > so after Rob hopefully has time to look at the binding change, I'd suspect > you take the code changes and I'll take the dts changes. Works for me.
On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote: > Hardware needs a delay between setting an initial (non-zero) PWM and > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > this delay in milli seconds. Hardware also needs a delay between disabing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Acked-by: Pavel Machek <pavel@ucw.cz> Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > Based on the original Huang Lin <hl@rock-chips.com> work. > > Changes since v4: > - Rebase on top of mainline. > Changes since v3: > - Replace us for ms. > - Add Acked-by: Pavel Machek <pavel@ucw.cz> > Changes since v2: > - Use separate properties (Rob Herring) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt > index 764db86d441a..310810906613 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt > +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt > @@ -17,6 +17,10 @@ Optional properties: > "pwms" property (see PWM binding[0]) > - enable-gpios: contains a single GPIO specifier for the GPIO which enables > and disables the backlight (see GPIO binding[1]) > + - post-pwm-on-delay-ms: Delay in ms between setting an initial (non-zero) PWM > + and enabling the backlight using GPIO. > + - pwm-off-delay-ms: Delay in ms between disabling the backlight using GPIO > + and setting PWM value to 0. > > [0]: Documentation/devicetree/bindings/pwm/pwm.txt > [1]: Documentation/devicetree/bindings/gpio/gpio.txt > @@ -32,4 +36,6 @@ Example: > > power-supply = <&vdd_bl_reg>; > enable-gpios = <&gpio 58 0>; > + post-pwm-on-delay-ms = <10>; > + pwm-off-delay-ms = <10>; > }; > -- > 2.15.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, oh, devicetree mailing list is not added, sorry, so cc'ing ... 2018-02-19 12:11 GMT+01:00 Daniel Thompson <daniel.thompson@linaro.org>: > On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote: >> Hardware needs a delay between setting an initial (non-zero) PWM and >> enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies >> this delay in milli seconds. Hardware also needs a delay between disabing >> the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms >> is this delay in milli seconds. >> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> Acked-by: Pavel Machek <pavel@ucw.cz> > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > Lee, I guess that after Daniel ack the only ack missing here is one from Rob Herring? Rob, if you have a chance to look at this I'd appreciate. Thanks, Enric >> --- >> Based on the original Huang Lin <hl@rock-chips.com> work. >> >> Changes since v4: >> - Rebase on top of mainline. >> Changes since v3: >> - Replace us for ms. >> - Add Acked-by: Pavel Machek <pavel@ucw.cz> >> Changes since v2: >> - Use separate properties (Rob Herring) >> Changes since v1: >> - As suggested by Daniel Thompson >> - Do not assume power-on delay and power-off delay will be the same >> >> Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt >> index 764db86d441a..310810906613 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt >> +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt >> @@ -17,6 +17,10 @@ Optional properties: >> "pwms" property (see PWM binding[0]) >> - enable-gpios: contains a single GPIO specifier for the GPIO which enables >> and disables the backlight (see GPIO binding[1]) >> + - post-pwm-on-delay-ms: Delay in ms between setting an initial (non-zero) PWM >> + and enabling the backlight using GPIO. >> + - pwm-off-delay-ms: Delay in ms between disabling the backlight using GPIO >> + and setting PWM value to 0. >> >> [0]: Documentation/devicetree/bindings/pwm/pwm.txt >> [1]: Documentation/devicetree/bindings/gpio/gpio.txt >> @@ -32,4 +36,6 @@ Example: >> >> power-supply = <&vdd_bl_reg>; >> enable-gpios = <&gpio 58 0>; >> + post-pwm-on-delay-ms = <10>; >> + pwm-off-delay-ms = <10>; >> }; >> -- >> 2.15.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
FAO Thierry, > oh, devicetree mailing list is not added, sorry, so cc'ing ... > > 2018-02-19 12:11 GMT+01:00 Daniel Thompson <daniel.thompson@linaro.org>: > > On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote: > >> Hardware needs a delay between setting an initial (non-zero) PWM and > >> enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > >> this delay in milli seconds. Hardware also needs a delay between disabing > >> the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > >> is this delay in milli seconds. > >> > >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > >> Acked-by: Pavel Machek <pavel@ucw.cz> > > > > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > > > > Lee, I guess that after Daniel ack the only ack missing here is one > from Rob Herring? I'd also like an ACK from the PWM Maintainer if possible. > Rob, if you have a chance to look at this I'd appreciate.
On Fri, Feb 16, 2018 at 06:40:31PM +0100, Enric Balletbo i Serra wrote: > Hardware needs a delay between setting an initial (non-zero) PWM and > enabling the backlight using GPIO. The post-pwm-on-delay-ms specifies > this delay in milli seconds. Hardware also needs a delay between disabing > the backlight using GPIO and setting PWM value to 0. The pwm-off-delay-ms > is this delay in milli seconds. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Acked-by: Pavel Machek <pavel@ucw.cz> > --- > Based on the original Huang Lin <hl@rock-chips.com> work. > > Changes since v4: > - Rebase on top of mainline. > Changes since v3: > - Replace us for ms. > - Add Acked-by: Pavel Machek <pavel@ucw.cz> > Changes since v2: > - Use separate properties (Rob Herring) > Changes since v1: > - As suggested by Daniel Thompson > - Do not assume power-on delay and power-off delay will be the same > > Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt | 6 ++++++ > 1 file changed, 6 insertions(+) Acked-by: Thierry Reding <thierry.reding@gmail.com>
diff --git a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt index 764db86d441a..310810906613 100644 --- a/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt +++ b/Documentation/devicetree/bindings/leds/backlight/pwm-backlight.txt @@ -17,6 +17,10 @@ Optional properties: "pwms" property (see PWM binding[0]) - enable-gpios: contains a single GPIO specifier for the GPIO which enables and disables the backlight (see GPIO binding[1]) + - post-pwm-on-delay-ms: Delay in ms between setting an initial (non-zero) PWM + and enabling the backlight using GPIO. + - pwm-off-delay-ms: Delay in ms between disabling the backlight using GPIO + and setting PWM value to 0. [0]: Documentation/devicetree/bindings/pwm/pwm.txt [1]: Documentation/devicetree/bindings/gpio/gpio.txt @@ -32,4 +36,6 @@ Example: power-supply = <&vdd_bl_reg>; enable-gpios = <&gpio 58 0>; + post-pwm-on-delay-ms = <10>; + pwm-off-delay-ms = <10>; };