diff mbox series

[U-Boot,1/4] fpga: Added Kconfig support for FPGA_SPARTAN3

Message ID 1518784372-14228-2-git-send-email-vipulk@xilinx.com
State Accepted
Delegated to: Tom Rini
Headers show
Series fpga: Moved fpga u-boot headers to the Kconfig | expand

Commit Message

Vipul Kumar Feb. 16, 2018, 12:32 p.m. UTC 
This patch added Kconfig support for FPGA_SPARTAN3.

Signed-off-by: Vipul Kumar <vipulk@xilinx.com>
Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
---
 drivers/fpga/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

--
2.7.4

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Comments

Tom Rini Feb. 28, 2018, 8:24 p.m. UTC | #1 
On Fri, Feb 16, 2018 at 06:02:49PM +0530, Vipul Kumar wrote:

> This patch added Kconfig support for FPGA_SPARTAN3.
> 
> Signed-off-by: Vipul Kumar <vipulk@xilinx.com>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>

After merging 2/4 into this (we should always update the defconfigs in
the patch, otherwise we may get build warnings later when bisecting),
applied to u-boot/master, thanks!
Michal Simek March 1, 2018, 7:05 a.m. UTC | #2 
Hi Tom,

On 28.2.2018 21:24, Tom Rini wrote:
> On Fri, Feb 16, 2018 at 06:02:49PM +0530, Vipul Kumar wrote:
> 
>> This patch added Kconfig support for FPGA_SPARTAN3.
>>
>> Signed-off-by: Vipul Kumar <vipulk@xilinx.com>
>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> 
> After merging 2/4 into this (we should always update the defconfigs in
> the patch, otherwise we may get build warnings later when bisecting),
> applied to u-boot/master, thanks!
> 

I am collecting these Kconfig patches in this branch (I have rebased it now)
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/kconfig

Do you want to get these patches before 2018.03 tag?

Thanks,
Michal
Tom Rini March 1, 2018, 2:28 p.m. UTC | #3 
On Thu, Mar 01, 2018 at 08:05:59AM +0100, Michal Simek wrote:
> Hi Tom,
> 
> On 28.2.2018 21:24, Tom Rini wrote:
> > On Fri, Feb 16, 2018 at 06:02:49PM +0530, Vipul Kumar wrote:
> > 
> >> This patch added Kconfig support for FPGA_SPARTAN3.
> >>
> >> Signed-off-by: Vipul Kumar <vipulk@xilinx.com>
> >> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> > 
> > After merging 2/4 into this (we should always update the defconfigs in
> > the patch, otherwise we may get build warnings later when bisecting),
> > applied to u-boot/master, thanks!
> > 
> 
> I am collecting these Kconfig patches in this branch (I have rebased it now)
> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/kconfig
> 
> Do you want to get these patches before 2018.03 tag?

If they're size-neutral (or understandably why), yes.  I can even give a
pull and build, if you don't have a machine you can do that on easily
(or don't want to setup a gcompute node or whatever).
Michal Simek March 1, 2018, 2:30 p.m. UTC | #4 
On 1.3.2018 15:28, Tom Rini wrote:
> On Thu, Mar 01, 2018 at 08:05:59AM +0100, Michal Simek wrote:
>> Hi Tom,
>>
>> On 28.2.2018 21:24, Tom Rini wrote:
>>> On Fri, Feb 16, 2018 at 06:02:49PM +0530, Vipul Kumar wrote:
>>>
>>>> This patch added Kconfig support for FPGA_SPARTAN3.
>>>>
>>>> Signed-off-by: Vipul Kumar <vipulk@xilinx.com>
>>>> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>>>
>>> After merging 2/4 into this (we should always update the defconfigs in
>>> the patch, otherwise we may get build warnings later when bisecting),
>>> applied to u-boot/master, thanks!
>>>
>>
>> I am collecting these Kconfig patches in this branch (I have rebased it now)
>> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/kconfig
>>
>> Do you want to get these patches before 2018.03 tag?
> 
> If they're size-neutral (or understandably why), yes.  I can even give a
> pull and build, if you don't have a machine you can do that on easily
> (or don't want to setup a gcompute node or whatever).
> 

Ok. They are supposed to be size neutral.
I will review that v2 which Vipul sent and will send you pull request
when I am done.

Thanks,
Michal
diff mbox series

Patch

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 6b2c866..ac08bc1 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -45,4 +45,9 @@  config FPGA_ZYNQMPPL
          Enable FPGA driver for loading bitstream in BIT and BIN format
          on Xilinx Zynq UltraScale+ (ZynqMP) device.

+config FPGA_SPARTAN3
+       bool "Enable Spartan3 FPGA driver"
+       help
+         Enable Spartan3 FPGA driver for loading in BIT format.
+
 endmenu