[2/2] python-watchdog: add missing runtime dependency

Message ID 1518787921-32089-2-git-send-email-yegorslists@googlemail.com
State Accepted
Headers show
Series
  • Untitled series #28996
Related show

Commit Message

Yegor Yefremov Feb. 16, 2018, 1:32 p.m.
From: Yegor Yefremov <yegorslists@googlemail.com>

Script watchmedo requires python-setuptools.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python-watchdog/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni April 28, 2018, 9:37 p.m. | #1
Hello,

On Fri, 16 Feb 2018 14:32:01 +0100, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Script watchmedo requires python-setuptools.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python-watchdog/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/python-watchdog/Config.in b/package/python-watchdog/Config.in
> index e529089..18f569e 100644
> --- a/package/python-watchdog/Config.in
> +++ b/package/python-watchdog/Config.in
> @@ -1,8 +1,9 @@
>  config BR2_PACKAGE_PYTHON_WATCHDOG
>  	bool "python-watchdog"
> -	select BR2_PACKAGE_PYTHON_PYYAML
> -	select BR2_PACKAGE_PYTHON_ARGH
> -	select BR2_PACKAGE_PYTHON_PATHTOOLS
> +	select BR2_PACKAGE_PYTHON_ARGH # runtime
> +	select BR2_PACKAGE_PYTHON_PATHTOOLS # runtime
> +	select BR2_PACKAGE_PYTHON_PYYAML # runtime
> +	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime

I applied, but since this dependency is only needed for the
watchmedo.py script, does it make sense to make this a mandatory
dependency ?

Also, skimming through the watchmedo.py script, I couldn't see what was
bringing this dependecny on setuptools. Could you enlighten me (it's
mainly for my own curiosity, I trust you when you said it was needed).

Applied, thanks!

Thomas
Yegor Yefremov April 29, 2018, 9 a.m. | #2
On Sat, Apr 28, 2018 at 11:37 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Fri, 16 Feb 2018 14:32:01 +0100, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> Script watchmedo requires python-setuptools.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>>  package/python-watchdog/Config.in | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/python-watchdog/Config.in b/package/python-watchdog/Config.in
>> index e529089..18f569e 100644
>> --- a/package/python-watchdog/Config.in
>> +++ b/package/python-watchdog/Config.in
>> @@ -1,8 +1,9 @@
>>  config BR2_PACKAGE_PYTHON_WATCHDOG
>>       bool "python-watchdog"
>> -     select BR2_PACKAGE_PYTHON_PYYAML
>> -     select BR2_PACKAGE_PYTHON_ARGH
>> -     select BR2_PACKAGE_PYTHON_PATHTOOLS
>> +     select BR2_PACKAGE_PYTHON_ARGH # runtime
>> +     select BR2_PACKAGE_PYTHON_PATHTOOLS # runtime
>> +     select BR2_PACKAGE_PYTHON_PYYAML # runtime
>> +     select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
>
> I applied, but since this dependency is only needed for the
> watchmedo.py script, does it make sense to make this a mandatory
> dependency ?

We make it already for some other packages like crossbar for example.

> Also, skimming through the watchmedo.py script, I couldn't see what was
> bringing this dependecny on setuptools. Could you enlighten me (it's
> mainly for my own curiosity, I trust you when you said it was needed).

The whole entry_points mechanism is described here:
https://stackoverflow.com/a/9615473/1113139
That's why setuptools package is needed on target.

Yegor

> Applied, thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
Peter Korsgaard May 1, 2018, 7:32 a.m. | #3
>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > Script watchmedo requires python-setuptools.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed to 2018.02.x, thanks.

Patch

diff --git a/package/python-watchdog/Config.in b/package/python-watchdog/Config.in
index e529089..18f569e 100644
--- a/package/python-watchdog/Config.in
+++ b/package/python-watchdog/Config.in
@@ -1,8 +1,9 @@ 
 config BR2_PACKAGE_PYTHON_WATCHDOG
 	bool "python-watchdog"
-	select BR2_PACKAGE_PYTHON_PYYAML
-	select BR2_PACKAGE_PYTHON_ARGH
-	select BR2_PACKAGE_PYTHON_PATHTOOLS
+	select BR2_PACKAGE_PYTHON_ARGH # runtime
+	select BR2_PACKAGE_PYTHON_PATHTOOLS # runtime
+	select BR2_PACKAGE_PYTHON_PYYAML # runtime
+	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
 	help
 	  Python API and shell utilities to monitor file system events.