diff mbox series

[LEDE-DEV,mountd] mount: reorder deleting code in the mount_enum_drives()

Message ID 20180216115024.3486-1-zajec5@gmail.com
State Accepted
Delegated to: Rafał Miłecki
Headers show
Series [LEDE-DEV,mountd] mount: reorder deleting code in the mount_enum_drives() | expand

Commit Message

Rafał Miłecki Feb. 16, 2018, 11:50 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

Make it execute required unmount code first and then take care of
removing entry from the internal list. This is a small cleanup grouping
code by their purpose.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 mount.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/mount.c b/mount.c
index bf5fbfd..6fefd9d 100644
--- a/mount.c
+++ b/mount.c
@@ -757,16 +757,18 @@  static void mount_enum_drives(void)
 		if(!check_block(q->dev)||del)
 		{
 			mount_dev_del(q);
-			p->prev->next = p->next;
-			p->next->prev = p->prev;
-			p = p->next;
 			if (q->status == STATUS_MOUNTED || q->status == STATUS_EXPIRED) {
 				snprintf(tmp, 64, "%s%s", uci_path, q->name);
 				log_printf("unlinking %s\n", tmp);
 				unlink(tmp);
 				system_printf("ACTION=remove DEVICE=%s NAME=%s /sbin/hotplug-call mount", q->dev, q->name);
 			}
+
+			p->prev->next = p->next;
+			p->next->prev = p->prev;
+			p = p->next;
 			free(q);
+
 			mount_dump_uci_state();
 			system_printf("/etc/fonstated/ReloadSamba");
 		} else p = p->next;