| Message ID | 1518702707-7077-8-git-send-email-vsementsov@virtuozzo.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/9] nbd/server: add nbd_opt_invalid helper | expand |
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> > --- > tests/qemu-iotests/iotests.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) What breaks if they aren't moved? But stylistically, this looks reasonable; and can be merged independently of NBD stuff if someone else wants. Reviewed-by: Eric Blake <eblake@redhat.com>
16.02.2018 23:44, Eric Blake wrote: > On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> >> --- >> tests/qemu-iotests/iotests.py | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > What breaks if they aren't moved? But stylistically, this looks > reasonable; and can be merged independently of NBD stuff if someone > else wants. This movement also make it a bit nearer to PEP8, as it dislike "E402 module level import not at top of file", because of "sys.path.append" before imports.. So, I'd just saved as many imports as I could) > > Reviewed-by: Eric Blake <eblake@redhat.com> >
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 1bcc9ca57d..c1302a2f9b 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -23,13 +23,14 @@ import subprocess import string import unittest import sys -sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'scripts')) -import qtest import struct import json import signal import logging +sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'scripts')) +import qtest + # This will not work if arguments contain spaces but is necessary if we # want to support the override options that ./check supports.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)