| Message ID | 1300362011-8653-1-git-send-email-segoon@openwall.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2011-03-17 at 14:40 +0300, Vasiliy Kulikov wrote: > struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on > x86_64. These bytes are not initialized in the variable 'ah' before > sending 'ah' to the network. This leads to 4 bytes kernel stack > infoleak. > > This bug was introduced before the git epoch. > > Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Well spotted. Thanks for the patch. Acked-by: Phil Blundell <philb@gnu.org> p. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Phil Blundell <philb@gnu.org> Date: Thu, 17 Mar 2011 11:50:01 +0000 > On Thu, 2011-03-17 at 14:40 +0300, Vasiliy Kulikov wrote: >> struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on >> x86_64. These bytes are not initialized in the variable 'ah' before >> sending 'ah' to the network. This leads to 4 bytes kernel stack >> infoleak. >> >> This bug was introduced before the git epoch. >> >> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> > > Well spotted. Thanks for the patch. > > Acked-by: Phil Blundell <philb@gnu.org> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index 0c28263..116d3fd 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -435,10 +435,10 @@ static int econet_sendmsg(struct kiocb *iocb, struct socket *sock, udpdest.sin_addr.s_addr = htonl(network | addr.station); } + memset(&ah, 0, sizeof(ah)); ah.port = port; ah.cb = cb & 0x7f; ah.code = 2; /* magic */ - ah.pad = 0; /* tack our header on the front of the iovec */ size = sizeof(struct aunhdr);
struct aunhdr has 4 padding bytes between 'pad' and 'handle' fields on x86_64. These bytes are not initialized in the variable 'ah' before sending 'ah' to the network. This leads to 4 bytes kernel stack infoleak. This bug was introduced before the git epoch. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> --- net/econet/af_econet.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)