From patchwork Wed Feb 14 23:18:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Gregory Rose X-Patchwork-Id: 873570 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MZ6R6tcv"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zhb4S70MYz9t2l for ; Thu, 15 Feb 2018 10:20:56 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 03F57FBB; Wed, 14 Feb 2018 23:18:36 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id DCE3AF3D for ; Wed, 14 Feb 2018 23:18:33 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9A94C405 for ; Wed, 14 Feb 2018 23:18:33 +0000 (UTC) Received: by mail-pl0-f65.google.com with SMTP id v3so9411654plg.3 for ; Wed, 14 Feb 2018 15:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ebeM6dJfMdlnnn3uE7Trs+i9nwGAU6sXHXH2aNfBlqU=; b=MZ6R6tcvuc4TYg1zsqCtBqUk30EUnD52ylA+q5gSY8Jrx7z9ryfRrLYgVfX4thJP40 +XQwlgpvr7yfhit6MqIxThTBKIiP0hsqh4FdZLiiC7uOWqkkGgqSOR3ilzRzi13LiRZG ffIiQCaaoOvjGZlKUpOAhx4noD2Ek6GnDL8LRKKp3hvYLEmTKAIGjsOQh+FIzntuCIAG PQcJHRL21XR+HgmxLfNPBabw3gJZGjrh8gjycyUaOi3zxLWEQs8CXnU9s1Oq0bsI7QtA 7WeJetNR4EPbk6w3t6bbd4YNc0UPPCUalhl64k60AdH3q3aZHbOxE3KBZ8zvqvwqSq8H TLPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ebeM6dJfMdlnnn3uE7Trs+i9nwGAU6sXHXH2aNfBlqU=; b=rorwK9DBdrUM9CYtx0ZnsQngYGY3Bn2B7w/h1kyhtKwy53sjlaIbegimpBf33Y2nzl 4O38RF3T2Ux86v6zUINOBSYNUOgnprS/JQKBGFJOTxP0gaCP8Rp0vRC7vF5V3MKdQIby al8OaK1IfURbTkaKZmoSAKJulaA0Jd260hAi7n2OUN+7RZTG9pFUVfaXVuHDdeGXLkWT Pwa0rVKj0cI0tfi0Snsa96FVUWRGKDdJdUHiCazTP2Ck5cxgDkxZ7rTmdqnVkN4A7HMy 7JYrP0XwtAeRXmc71ZhS9h8M51XG4UJx7Dk4OYVOTkzu6wVoHhoUWkZV8phox04Imr4A LJFQ== X-Gm-Message-State: APf1xPA43mM7NH/msg0O33fYmvKeyUy3IRq0TyBtoBIRgsJbWIyZsXCS 8Np3EgDZrKm+T8qOQL6ZwB7QgQ== X-Google-Smtp-Source: AH8x227Qyk4DfUWN6VHa7z3sDOky82HrIhrLn/5bWexbHhBmxpqpl9t0Y/sFpn73kmDGROnHYopt2Q== X-Received: by 2002:a17:902:5a3:: with SMTP id f32-v6mr614018plf.48.1518650312898; Wed, 14 Feb 2018 15:18:32 -0800 (PST) Received: from gizo.domain (184-100-240-187.ptld.qwest.net. [184.100.240.187]) by smtp.gmail.com with ESMTPSA id v1sm34681912pfg.33.2018.02.14.15.18.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 15:18:32 -0800 (PST) From: Greg Rose To: dev@openvswitch.org Date: Wed, 14 Feb 2018 15:18:07 -0800 Message-Id: <1518650290-31536-6-git-send-email-gvrose8192@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1518650290-31536-1-git-send-email-gvrose8192@gmail.com> References: <1518650290-31536-1-git-send-email-gvrose8192@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: =?utf-8?q?Christopher_D=C3=ADaz_Riveros?= Subject: [ovs-dev] [PATCH 5/8] datapath: Remove unneeded semicolons X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Christopher Díaz Riveros Upstream commit: commit 89290b831ec1a0b233fdc7aaad84acdf4ebbf6aa Author: Christopher Díaz Riveros Date: Wed Jan 17 16:10:28 2018 -0500 flow_netlink: Remove unneeded semicolons Trivial fix removes unneeded semicolons after if blocks. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros Signed-off-by: David S. Miller Cc: Christopher Díaz Riveros Signed-off-by: Greg Rose --- datapath/flow_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c index 8eabc16..e2ccf91 100644 --- a/datapath/flow_netlink.c +++ b/datapath/flow_netlink.c @@ -2458,7 +2458,7 @@ static int validate_geneve_opts(struct sw_flow_key *key) option = (struct geneve_opt *)((u8 *)option + len); opts_len -= len; - }; + } key->tun_key.tun_flags |= crit_opt ? TUNNEL_CRIT_OPT : 0; @@ -2491,7 +2491,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr, case OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS: break; } - }; + } start = add_nested_action_start(sfa, OVS_ACTION_ATTR_SET, log); if (start < 0)