From patchwork Wed Feb 14 23:18:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Rose X-Patchwork-Id: 873568 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EZcbIR7f"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zhb3Y2rN9z9t2l for ; Thu, 15 Feb 2018 10:20:09 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 01857F51; Wed, 14 Feb 2018 23:18:32 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8E4FAF00 for ; Wed, 14 Feb 2018 23:18:30 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl0-f68.google.com (mail-pl0-f68.google.com [209.85.160.68]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id EF0821C0 for ; Wed, 14 Feb 2018 23:18:29 +0000 (UTC) Received: by mail-pl0-f68.google.com with SMTP id w21so2413245plp.11 for ; Wed, 14 Feb 2018 15:18:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FzafRfaRBZovQJ3WVflE5c+CBlE3/aK9aUfaHMcU6no=; b=EZcbIR7fqt2w+mhGMf+BbpNsN74poA/5vK1UZLsZr5gZala/BtZYnY5gIW+x+TFAXH xsoJmh3d53B7rCYTIyJpFf3BOTTwCP3gmby74fXTZhqZhw3Y48zKE1o4BEZvISyQ9N7Y GVPmOEXSLjB7LBW/H2K6clbC4J9Eyclg8Y2gzePEWMH336oKPtnKWWSF8z6vT1Tz50lF 9mGPJboM4lqK7H90F0RnKJbUPnNOtua8dYMJGPhyXO2jX1A40oVjQoFxYOEZdUqFRd6K SUhQSunt+sdzD952Xkzwrfejv//qytWlFf1pWDp8Jl/AJIaQ4arrx5x5q/loBJKUbltQ znKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FzafRfaRBZovQJ3WVflE5c+CBlE3/aK9aUfaHMcU6no=; b=N4FT5FQD83wKa56iyQMwx/8MDrR5KBk8A0TJt6ljt/R+NQXhQXMsDAlJufSxxQDqA/ +FEz3N/e/THKrFMK2jYjCsZaB+Uld1LduFEPHipKQ0euzl+/PtJ/JP3YMjWR9W4Izmqu SBujWsCcsUnpHKrx2xnn7aR239Wxyep1r3iXtDrD8QLUltmZzjRqMmwx+T0IRVUEd4lD u48qLniPZtRlOdA4n0TKV4Ea/YRXV1r5NtJ6PZKnvQwGVa9MSoyYgtYSzuk4EJXGr6r4 INeul2ACwphhbLgsAsyGiVgl/jxpqTRTgLr6aOhYIU0Mt8PowivI8wbQkilMsPmbr9YY kIJA== X-Gm-Message-State: APf1xPBAW7MmXtZecZ064CzgDOB5LERQUgMUbp7aSHTnDfaNBAZLEVkK VO0SQsH6MUeqawszkls7ALnnZQ== X-Google-Smtp-Source: AH8x226L38RG6OQ83aT6ytv+3nwSGhZYnnBr69A2iV5U4Tz8WXSEjLkPzygYpFRGwsleFoFtgszg3A== X-Received: by 2002:a17:902:6b82:: with SMTP id p2-v6mr618311plk.30.1518650309195; Wed, 14 Feb 2018 15:18:29 -0800 (PST) Received: from gizo.domain (184-100-240-187.ptld.qwest.net. [184.100.240.187]) by smtp.gmail.com with ESMTPSA id v1sm34681912pfg.33.2018.02.14.15.18.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Feb 2018 15:18:28 -0800 (PST) From: Greg Rose To: dev@openvswitch.org Date: Wed, 14 Feb 2018 15:18:05 -0800 Message-Id: <1518650290-31536-4-git-send-email-gvrose8192@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1518650290-31536-1-git-send-email-gvrose8192@gmail.com> References: <1518650290-31536-1-git-send-email-gvrose8192@gmail.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Julia Lawall Subject: [ovs-dev] [PATCH 3/8] datapath: drop unneeded newline X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Julia Lawall Upstream commit: commit e0b10844d9e617a1a5ce2ddf73d38aaa0a47a2a4 Author: Julia Lawall Date: Wed Dec 27 15:51:38 2017 +0100 openvswitch: drop unneeded newline OVS_NLERR prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: David S. Miller Cc: Julia Lawall Signed-off-by: Greg Rose --- datapath/conntrack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index a75ae3c..d58240b 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c @@ -1315,14 +1315,14 @@ static int parse_nat(const struct nlattr *attr, /* Do not allow flags if no type is given. */ if (info->range.flags) { OVS_NLERR(log, - "NAT flags may be given only when NAT range (SRC or DST) is also specified.\n" + "NAT flags may be given only when NAT range (SRC or DST) is also specified." ); return -EINVAL; } info->nat = OVS_CT_NAT; /* NAT existing connections. */ } else if (!info->commit) { OVS_NLERR(log, - "NAT attributes may be specified only when CT COMMIT flag is also specified.\n" + "NAT attributes may be specified only when CT COMMIT flag is also specified." ); return -EINVAL; }