From patchwork Thu Mar 17 03:04:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dennis Aberilla X-Patchwork-Id: 87332 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gy0-f184.google.com (mail-gy0-f184.google.com [209.85.160.184]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 78E64B6FF5 for ; Thu, 17 Mar 2011 14:05:06 +1100 (EST) Received: by gyg10 with SMTP id 10sf1779166gyg.11 for ; Wed, 16 Mar 2011 20:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf :x-yahoo-newman-property:x-yahoo-newman-id:message-id:x-ymail-osg :x-mailer:date:from:subject:to:cc:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=Q0wGw6BD9fPzdnTLYP8TQRWUnZgXGifFdpKNE5uarZs=; b=I4/vp9TqiekRf0tDpWMvHONR2+jPR6xKzZOsvhdZy5CQqfNm9ZfDOvllHyNCQKYqE9 jAjjBA6kpNyr5IBWX+8XM3upf8qSrLCRWKbXe6hrG7ZoMVXqzI3t7Zv9JoEjhLbWh3Oo 0AgDrVA73WGXC3H9soTRlyi2jlx/IkcEMy6Ao= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:x-yahoo-newman-property:x-yahoo-newman-id :message-id:x-ymail-osg:x-mailer:date:from:subject:to:cc :mime-version:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-transfer-encoding; b=z8UA2+2d3XUFqyELzoO69hD8MMWj0WaIvb0mP/ZPBOfrzcPtiVdv32H8Wqt1SsreIR NFlgjhvU5qWMZ3v310KvATcsuKE7c2/iPSPQE633CSf7Rr2CXZLKTKAjdnUmd8Tpf0uM EVnmrtk/zSXOMGlPKakIYqL6768VeDb4tx1+w= Received: by 10.151.60.13 with SMTP id n13mr179022ybk.60.1300331101992; Wed, 16 Mar 2011 20:05:01 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.231.2.82 with SMTP id 18ls2069055ibi.2.p; Wed, 16 Mar 2011 20:05:00 -0700 (PDT) Received: by 10.42.229.9 with SMTP id jg9mr90444icb.60.1300331100199; Wed, 16 Mar 2011 20:05:00 -0700 (PDT) Received: by 10.42.229.9 with SMTP id jg9mr90443icb.60.1300331100183; Wed, 16 Mar 2011 20:05:00 -0700 (PDT) Received: from nm1.bullet.mail.ne1.yahoo.com (nm1.bullet.mail.ne1.yahoo.com [98.138.90.64]) by gmr-mx.google.com with SMTP id c4si288267ict.3.2011.03.16.20.05.00; Wed, 16 Mar 2011 20:05:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of denzzzhome@yahoo.com designates 98.138.90.64 as permitted sender) client-ip=98.138.90.64; Received: from [98.138.90.53] by nm1.bullet.mail.ne1.yahoo.com with NNFMP; 17 Mar 2011 03:04:59 -0000 Received: from [98.138.89.244] by tm6.bullet.mail.ne1.yahoo.com with NNFMP; 17 Mar 2011 03:04:59 -0000 Received: from [127.0.0.1] by omp1058.mail.ne1.yahoo.com with NNFMP; 17 Mar 2011 03:04:59 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 883987.71426.bm@omp1058.mail.ne1.yahoo.com Received: (qmail 37810 invoked by uid 60001); 17 Mar 2011 03:04:59 -0000 Message-ID: <694698.37646.qm@web120506.mail.ne1.yahoo.com> X-YMail-OSG: VHmwbccVM1kseHMMjlSeUJQolTNe.o2QdUvlLuR9Z0CHGiE OaJqqUPhQfTZZL4fnivIjLmkp3dB98plW3ijyc5g3xdn9mJ9Ce.IwbZx1DC6 2fVjb5NqZRDwS2Rt5zTRNSwHXOYtlYa33_a32UBDmobSyZOT.DIjW9QumMxh 72zxkDn.6gmjqkiIPrjAOzrLrpw8W26cjN6JIK1A1CAOoand6d8MixP_hMuB ouTwZRNNtxBoTgYi9RowFmPs.RsHokcJPeATdupvKfZuBhnWgbrsjIm45324 IYsBxQ8NiNnc0AY2q33b54FxCji55ug8SUx6uJaoBKRR5PGvfpoGxfvY.54e lxHes0Rz8BwMyPMm9hkgF7IWXNF8- Received: from [202.37.96.35] by web120506.mail.ne1.yahoo.com via HTTP; Wed, 16 Mar 2011 20:04:59 PDT X-Mailer: YahooMailClassic/11.4.20 YahooMailWebService/0.8.109.295617 Date: Wed, 16 Mar 2011 20:04:59 -0700 (PDT) From: Dennis Aberilla Subject: [rtc-linux] Re: [PATCH] rtc: rtc-ds1390/rtc-ds3234/rtc-m41t94: eliminate compile warning To: linux-kernel@vger.kernel.org, Axel Lin Cc: Mark Jackson , "Kim B. Heino" , Alessandro Zummo , Thomas Gleixner , rtc-linux@googlegroups.com MIME-Version: 1.0 X-Original-Sender: denzzzhome@yahoo.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of denzzzhome@yahoo.com designates 98.138.90.64 as permitted sender) smtp.mail=denzzzhome@yahoo.com; dkim=pass (test mode) header.i=@yahoo.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Hi Axel, that doesn't seem to make sense to me since "platform_get_drvdata" is (from include/linux/platform_device.h): #define platform_get_drvdata(_dev) dev_get_drvdata(&(_dev)->dev) |Dennis --- On Thu, 24/2/11, Axel Lin wrote: From: Axel Lin Subject: [PATCH] rtc: rtc-ds1390/rtc-ds3234/rtc-m41t94: eliminate compile warning To: linux-kernel@vger.kernel.org Cc: "Mark Jackson" , "Dennis Aberilla" , "Kim B. Heino" , "Alessandro Zummo" , "Thomas Gleixner" , rtc-linux@googlegroups.com Received: Thursday, 24 February, 2011, 9:28 AM Eliminate the following compile warning: drivers/rtc/rtc-ds1390.c: In function 'ds1390_remove': drivers/rtc/rtc-ds1390.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type drivers/rtc/rtc-ds3234.c: In function 'ds3234_remove': drivers/rtc/rtc-ds3234.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type drivers/rtc/rtc-m41t94.c: In function 'm41t94_remove': drivers/rtc/rtc-m41t94.c:139: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type Signed-off-by: Axel Lin Cc: Mark Jackson Cc: Dennis Aberilla Cc: Kim B. Heino --- drivers/rtc/rtc-ds1390.c |    2 +- drivers/rtc/rtc-ds3234.c |    2 +- drivers/rtc/rtc-m41t94.c |    2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c index 26a86d2..4832248 100644 --- a/drivers/rtc/rtc-ds1390.c +++ b/drivers/rtc/rtc-ds1390.c @@ -158,7 +158,7 @@ static int __devinit ds1390_probe(struct spi_device *spi) static int __devexit ds1390_remove(struct spi_device *spi) { -    struct ds1390 *chip = platform_get_drvdata(spi); +    struct ds1390 *chip = dev_get_drvdata(&spi->dev);     rtc_device_unregister(chip->rtc);     kfree(chip); diff --git a/drivers/rtc/rtc-ds3234.c b/drivers/rtc/rtc-ds3234.c index a774ca3..07a558e 100644 --- a/drivers/rtc/rtc-ds3234.c +++ b/drivers/rtc/rtc-ds3234.c @@ -158,7 +158,7 @@ static int __devinit ds3234_probe(struct spi_device *spi) static int __devexit ds3234_remove(struct spi_device *spi) { -    struct rtc_device *rtc = platform_get_drvdata(spi); +    struct rtc_device *rtc = dev_get_drvdata(&spi->dev);     rtc_device_unregister(rtc);     return 0; diff --git a/drivers/rtc/rtc-m41t94.c b/drivers/rtc/rtc-m41t94.c index c8c97a4..21e6091 100644 --- a/drivers/rtc/rtc-m41t94.c +++ b/drivers/rtc/rtc-m41t94.c @@ -136,7 +136,7 @@ static int __devinit m41t94_probe(struct spi_device *spi) static int __devexit m41t94_remove(struct spi_device *spi) { -    struct rtc_device *rtc = platform_get_drvdata(spi); +    struct rtc_device *rtc = dev_get_drvdata(&spi->dev);     if (rtc)         rtc_device_unregister(rtc);