wpa_supplicant/Makefile: use $(LIBS) with wpa_passphrase

Message ID 20180213224908.GA19347@comp.lan
State Accepted
Headers show
Series
  • wpa_supplicant/Makefile: use $(LIBS) with wpa_passphrase
Related show

Commit Message

Arkadiusz Drabczyk Feb. 13, 2018, 10:49 p.m.
wpa_passphrase requires libcrypto from OpenSSL.  User can set an
alternative path to OpenSSL libraries by defining LIBS at the top of
.config but if $(LIBS) is not actually used wrong libcrypto is used or
compilation fails if there is no libcrypto in the default locations cc
is looking for it.  It's especially bad for cross-compilers that fail
with 'cannot find -lcrypto' message.

Signed-off-by: Arkadiusz Drabczyk <arkadiusz@drabczyk.org>
---
 wpa_supplicant/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jouni Malinen Feb. 17, 2018, 7:19 p.m. | #1
On Tue, Feb 13, 2018 at 11:49:08PM +0100, Arkadiusz Drabczyk wrote:
> wpa_passphrase requires libcrypto from OpenSSL.  User can set an
> alternative path to OpenSSL libraries by defining LIBS at the top of
> .config but if $(LIBS) is not actually used wrong libcrypto is used or
> compilation fails if there is no libcrypto in the default locations cc
> is looking for it.  It's especially bad for cross-compilers that fail
> with 'cannot find -lcrypto' message.

Thanks, applied.

Patch

diff --git a/wpa_supplicant/Makefile b/wpa_supplicant/Makefile
index 4431755..39af773 100644
--- a/wpa_supplicant/Makefile
+++ b/wpa_supplicant/Makefile
@@ -1868,7 +1868,7 @@  preauth_test: $(OBJS_t2)
 	@$(E) "  LD " $@
 
 wpa_passphrase: $(OBJS_p)
-	$(Q)$(LDO) $(LDFLAGS) -o wpa_passphrase $(OBJS_p) $(LIBS_p)
+	$(Q)$(LDO) $(LDFLAGS) -o wpa_passphrase $(OBJS_p) $(LIBS_p) $(LIBS)
 	@$(E) "  LD " $@
 
 wpa_cli: $(OBJS_c)