ARC: Don't check presense of Timer1 in SMP builds

Message ID 20180213193504.28671-1-abrodkin@synopsys.com
State New
Headers show
Series
  • ARC: Don't check presense of Timer1 in SMP builds
Related show

Commit Message

Alexey Brodkin Feb. 13, 2018, 7:35 p.m.
In case of SMP we use GFRC from ARconnect and Timer1 is left
untouched. Still with that check in place we're panicing if Timer1
is missing in current hardware which is quite unexpected.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
---
 arch/arc/kernel/setup.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Vineet Gupta Feb. 13, 2018, 7:53 p.m. | #1
On 02/13/2018 11:35 AM, Alexey Brodkin wrote:
> In case of SMP we use GFRC from ARconnect and Timer1 is left
> untouched. Still with that check in place we're panicing if Timer1
> is missing in current hardware which is quite unexpected.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
>   arch/arc/kernel/setup.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index cf97f7d88934..1142d76a7e8f 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
>   	if (!cpu->extn.timer0)
>   		panic("Timer0 is not present!\n");
>   
> +#ifndef CONFIG_SMP
>   	if (!cpu->extn.timer1)
>   		panic("Timer1 is not present!\n");
> +#endif

Curious, you have a config w/o TIMER1, so is this a fallout of recent discussions !

-Vineet

Patch

diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index cf97f7d88934..1142d76a7e8f 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -391,8 +391,10 @@  static void arc_chk_core_config(void)
 	if (!cpu->extn.timer0)
 		panic("Timer0 is not present!\n");
 
+#ifndef CONFIG_SMP
 	if (!cpu->extn.timer1)
 		panic("Timer1 is not present!\n");
+#endif
 
 #ifdef CONFIG_ARC_HAS_DCCM
 	/*