From patchwork Tue Feb 13 18:18:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 873106 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zgrRt0YdMz9sRm for ; Wed, 14 Feb 2018 05:20:08 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 4EAF7C21F8C; Tue, 13 Feb 2018 18:19:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B5DB9C21E76; Tue, 13 Feb 2018 18:19:56 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 619FBC21F8C; Tue, 13 Feb 2018 18:19:55 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lists.denx.de (Postfix) with ESMTPS id 0EA58C21E76 for ; Tue, 13 Feb 2018 18:19:55 +0000 (UTC) Received: from workstation4.fritz.box ([88.152.14.75]) by mail.gmx.com (mrgmx001 [212.227.17.184]) with ESMTPSA (Nemesis) id 0Lg1Tn-1eR9gR2xzP-00pdrm; Tue, 13 Feb 2018 19:19:52 +0100 From: Heinrich Schuchardt To: Tom Rini Date: Tue, 13 Feb 2018 19:18:58 +0100 Message-Id: <20180213181858.10063-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.14.2 X-Provags-ID: V03:K0:Y1jT649XDFPNlMnd4LaHXwhanVkc9WbBqWLpWZWKFbYUkdXuxie dcwz74MIrGjvwozxbz5LEEygvrgpgMo1LgtPsHd0WxycSi4fu6VzDyodM4/fHW2r+0sGchs 1XEXnBKlt2ZAG4tXUD4qm/TbkIaTtcky8itocuEwWzvYY1N83O1zDSyEO9Lgvn24fZYaPaU XKmMUdjxVyj6Yn3a2ptvA== X-UI-Out-Filterresults: notjunk:1; V01:K0:IcpENzDZ8Mk=:xqI+etLrI8IK8ZxeenC8Oi DsDMQl6+Y0xAdidfgtYmfGwOIaxBRRG4J1eg66THBdE0dMYIYdPQUju5jV6pylCUjGQTy/Jut lGrA2zXYOARjBe1JWtLCIvmRXDrOrA1nOjQE20ufAROy9Fz2RMWbquIlsQP9A19Dqp5mpvckM F7tYCHL9U2nM75cJErj+NJxISq0qZdm9/vGbGZ2lWX0+YOAkJWPcJa/YZ0fAW7jjpeehroQlB BADmS9ohNfBWd6GskdMwYD4rB4tKGZzzWK7BhIPXYa7erde9GmpnfxIG6avU05qEU//Kc4IU6 d81vEdprtyheSFW7w33zvxRGcwYbvuJiSOkOG0pcSu9KMalhbPP2AYxZNA0wPfaNAgQradBA0 UAmoeDyoPh+usUXWLDFspcxTV09HhWU8RzZb8Epn+9dV4c4T3zZLqlOn7+N94jhpWAxaPMe/s 0dywHtBXaF7WHI5YUHlxbvt1rGrran0sS7SgORtCLTrnyHslbKY18+k9gRs87OlBHOIFN6QA3 2qJkeh9gG3fMqJ1j/l2TTOeV+DElamlKs/X/qrzadCVMa7XdEaTPRDAYlVfY0Vl+LyVc8QHmB DsFk7U7s/89bSzZcjnIZ6BWrPyHUh7cPtSy+LhcjrqJVTkbz9qLCol7Yi6mRMAMqLtNjytvzD ehAn7lnLLgtoPFrqe4UCxlqZ27AHzbEnCy3nCE4ddnX1wt7911qT9NiBuhnuS+/DRPFz4sUGC jrxSfWJ4MBQLT4RhS9Rv/w9zaUz/KP315jIcPRnokFu93FJVo3HOgX5qhOPBvBAf16mUhb7Zi fvuDYZolVIic36AWByyhtGocPdtVw== Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] fs: fat: avoid useless conversion when calling getcluster X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Parameter size of function get_cluster() is of type unsigned long. It makes no sense to convert actsize to int before passing it to get_cluster as size. Signed-off-by: Heinrich Schuchardt Reviewed-by: Lukasz Majewski --- fs/fat/fat.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/fat/fat.c b/fs/fat/fat.c index dd7888cd6d4..a3c7bf604eb 100644 --- a/fs/fat/fat.c +++ b/fs/fat/fat.c @@ -353,7 +353,7 @@ static int get_contents(fsdata *mydata, dir_entry *dentptr, loff_t pos, if (pos) { actsize = min(filesize, (loff_t)bytesperclust); if (get_cluster(mydata, curclust, get_contents_vfatname_block, - (int)actsize) != 0) { + (unsigned long)actsize) != 0) { printf("Error reading cluster\n"); return -1; } @@ -393,14 +393,16 @@ static int get_contents(fsdata *mydata, dir_entry *dentptr, loff_t pos, /* get remaining bytes */ actsize = filesize; - if (get_cluster(mydata, curclust, buffer, (int)actsize) != 0) { + if (get_cluster(mydata, curclust, buffer, + (unsigned long)actsize) != 0) { printf("Error reading cluster\n"); return -1; } *gotsize += actsize; return 0; getit: - if (get_cluster(mydata, curclust, buffer, (int)actsize) != 0) { + if (get_cluster(mydata, curclust, buffer, + (unsigned long)actsize) != 0) { printf("Error reading cluster\n"); return -1; }