| Message ID | 20180213175245.17703-1-anto.cardace@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: nftl: use %*ph to print small buffer | expand |
On Tue, 2018-02-13 at 17:52 +0000, Antonio Cardace wrote: > Use %*ph format to print small buffer as hex string. > Any comments so far? > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Antonio Cardace <anto.cardace@gmail.com> > --- > > drivers/mtd/nftlmount.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c > index 184c8fbfe465..a8bdc1455b50 100644 > --- a/drivers/mtd/nftlmount.c > +++ b/drivers/mtd/nftlmount.c > @@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord > *nftl) > if (memcmp(buf, "ANAND", 6)) { > printk(KERN_NOTICE "ANAND header found at > 0x%x in mtd%d, but went away on reread!\n", > block * nftl->EraseSize, nftl- > >mbd.mtd->index); > - printk(KERN_NOTICE "New data are: %02x %02x > %02x %02x %02x %02x\n", > - buf[0], buf[1], buf[2], buf[3], > buf[4], buf[5]); > + printk(KERN_NOTICE "New data are: %6ph\n", > buf); > continue; > } > #endif
On Tue, 13 Feb 2018 17:52:45 +0000 Antonio Cardace <anto.cardace@gmail.com> wrote: > Use %*ph format to print small buffer as hex string. Applied. Thanks, Boris > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Antonio Cardace <anto.cardace@gmail.com> > --- > What about this one? > > drivers/mtd/nftlmount.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c > index 184c8fbfe465..a8bdc1455b50 100644 > --- a/drivers/mtd/nftlmount.c > +++ b/drivers/mtd/nftlmount.c > @@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl) > if (memcmp(buf, "ANAND", 6)) { > printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but went away on reread!\n", > block * nftl->EraseSize, nftl->mbd.mtd->index); > - printk(KERN_NOTICE "New data are: %02x %02x %02x %02x %02x %02x\n", > - buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]); > + printk(KERN_NOTICE "New data are: %6ph\n", buf); > continue; > } > #endif
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c index 184c8fbfe465..a8bdc1455b50 100644 --- a/drivers/mtd/nftlmount.c +++ b/drivers/mtd/nftlmount.c @@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl) if (memcmp(buf, "ANAND", 6)) { printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but went away on reread!\n", block * nftl->EraseSize, nftl->mbd.mtd->index); - printk(KERN_NOTICE "New data are: %02x %02x %02x %02x %02x %02x\n", - buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]); + printk(KERN_NOTICE "New data are: %6ph\n", buf); continue; } #endif
Use %*ph format to print small buffer as hex string. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Antonio Cardace <anto.cardace@gmail.com> --- What about this one? drivers/mtd/nftlmount.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)