| Message ID | 151852773680.28591.16836678561029630910.stgit@firesoul |
|---|---|
| State | Accepted, archived |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] net: avoid including xdp.h in filter.h | expand |
On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote: > If is sufficient with a forward declaration of struct xdp_rxq_info in > linux/filter.h, which avoids including net/xdp.h. This was originally > suggested by John Fastabend during the review phase, but wasn't > included in the final patchset revision. Thus, this followup. > > Suggested-by: John Fastabend <john.fastabend@gmail.com> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Applied to bpf-next, Thanks Jesper.
On 02/13/2018 05:57 PM, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote: >> If is sufficient with a forward declaration of struct xdp_rxq_info in >> linux/filter.h, which avoids including net/xdp.h. This was originally >> suggested by John Fastabend during the review phase, but wasn't >> included in the final patchset revision. Thus, this followup. >> >> Suggested-by: John Fastabend <john.fastabend@gmail.com> >> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> > > Applied to bpf-next, Thanks Jesper. > Great thanks for the follow up Jesper. Acked-by: John Fastabend <john.fastabend@gmail.com>
diff --git a/include/linux/filter.h b/include/linux/filter.h index 276932d75975..fdb691b520c0 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -20,7 +20,6 @@ #include <linux/set_memory.h> #include <linux/kallsyms.h> -#include <net/xdp.h> #include <net/sch_generic.h> #include <uapi/linux/filter.h> @@ -30,6 +29,7 @@ struct sk_buff; struct sock; struct seccomp_data; struct bpf_prog_aux; +struct xdp_rxq_info; /* ArgX, context and stack frame pointer register positions. Note, * Arg1, Arg2, Arg3, etc are used as argument mappings of function
If is sufficient with a forward declaration of struct xdp_rxq_info in linux/filter.h, which avoids including net/xdp.h. This was originally suggested by John Fastabend during the review phase, but wasn't included in the final patchset revision. Thus, this followup. Suggested-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> --- 0 files changed