Patchwork rtc-twl: Switch to using threaded irq

login
register
mail settings
Submitter Ilkka Koskinen
Date March 16, 2011, 4:07 p.m.
Message ID <1300291634-17884-1-git-send-email-ilkka.koskinen@nokia.com>
Download mbox | patch
Permalink /patch/87277/
State New
Headers show

Comments

Ilkka Koskinen - March 16, 2011, 4:07 p.m.
The driver is accessing to i2c bus in interrupt handler.
Therefore, it should use threaded irq.

Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
---
 drivers/rtc/rtc-twl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
balajitk@ti.com - April 13, 2011, 7:41 a.m.
On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
<ilkka.koskinen@nokia.com> wrote:
>
> The driver is accessing to i2c bus in interrupt handler.
> Therefore, it should use threaded irq.

Acked-by: Balaji T K <balajitk@ti.com>

>
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> ---
>  drivers/rtc/rtc-twl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> index ed1b868..2715b96 100644
> --- a/drivers/rtc/rtc-twl.c
> +++ b/drivers/rtc/rtc-twl.c
> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
>        if (ret < 0)
>                goto out1;
>
> -       ret = request_irq(irq, twl_rtc_interrupt,
> +       ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
>                                IRQF_TRIGGER_RISING,
>                                dev_name(&rtc->dev), rtc);
>        if (ret < 0) {
> --
> 1.7.0.4
>
Ilkka Koskinen - May 5, 2011, 7:51 a.m.
Hi,

Tony and John: What would be the appropriate path for this patch?

Cheers, Ilkka

On Apr 13, 2011 Krishnamoorthy, Balaji T  wrote:
>On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
<ilkka.koskinen@nokia.com> wrote:
>>
>> The driver is accessing to i2c bus in interrupt handler.
>> Therefore, it should use threaded irq.

>Acked-by: Balaji T K <balajitk@ti.com>

>>
>> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
>> ---
>>  drivers/rtc/rtc-twl.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
>> index ed1b868..2715b96 100644
>> --- a/drivers/rtc/rtc-twl.c
>> +++ b/drivers/rtc/rtc-twl.c
>> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
>>        if (ret < 0)
>>                goto out1;
>>
>> -       ret = request_irq(irq, twl_rtc_interrupt,
>> +       ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
>>                                IRQF_TRIGGER_RISING,
>>                                dev_name(&rtc->dev), rtc);
>>        if (ret < 0) {
>> --
>> 1.7.0.4
>>
John Stultz - May 12, 2011, 11:24 p.m.
On Thu, 2011-05-05 at 07:51 +0000, ilkka.koskinen@nokia.com wrote:
> Hi,
> 
> Tony and John: What would be the appropriate path for this patch?

I'd probably push it through omap maintainer path, as its hardware
specific and can be better tested there.

thanks
-john


> On Apr 13, 2011 Krishnamoorthy, Balaji T  wrote:
> >On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
> <ilkka.koskinen@nokia.com> wrote:
> >>
> >> The driver is accessing to i2c bus in interrupt handler.
> >> Therefore, it should use threaded irq.
> 
> >Acked-by: Balaji T K <balajitk@ti.com>
> 
> >>
> >> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> >> ---
> >>  drivers/rtc/rtc-twl.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> >> index ed1b868..2715b96 100644
> >> --- a/drivers/rtc/rtc-twl.c
> >> +++ b/drivers/rtc/rtc-twl.c
> >> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
> >>        if (ret < 0)
> >>                goto out1;
> >>
> >> -       ret = request_irq(irq, twl_rtc_interrupt,
> >> +       ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> >>                                IRQF_TRIGGER_RISING,
> >>                                dev_name(&rtc->dev), rtc);
> >>        if (ret < 0) {
> >> --
> >> 1.7.0.4
> >>
Ilkka Koskinen - May 18, 2011, 7:20 p.m.
Hi,

Tony, would you mind taking the patch in your tree?

Btw, the nokia address doesn't work anymore, but
should probably still remain in s-o-b...

Cheers, Ilkka

13.5.2011 2:24, John Stultz kirjoitti:
> On Thu, 2011-05-05 at 07:51 +0000, ilkka.koskinen@nokia.com wrote:
>> Hi,
>>
>> Tony and John: What would be the appropriate path for this patch?
> 
> I'd probably push it through omap maintainer path, as its hardware
> specific and can be better tested there.
> 
> thanks
> -john
> 
> 
>> On Apr 13, 2011 Krishnamoorthy, Balaji T  wrote:
>>> On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
>> <ilkka.koskinen@nokia.com> wrote:
>>>>
>>>> The driver is accessing to i2c bus in interrupt handler.
>>>> Therefore, it should use threaded irq.
>>
>>> Acked-by: Balaji T K <balajitk@ti.com>
>>
>>>>
>>>> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
>>>> ---
>>>>  drivers/rtc/rtc-twl.c |    2 +-
>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
>>>> index ed1b868..2715b96 100644
>>>> --- a/drivers/rtc/rtc-twl.c
>>>> +++ b/drivers/rtc/rtc-twl.c
>>>> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
>>>>        if (ret < 0)
>>>>                goto out1;
>>>>
>>>> -       ret = request_irq(irq, twl_rtc_interrupt,
>>>> +       ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
>>>>                                IRQF_TRIGGER_RISING,
>>>>                                dev_name(&rtc->dev), rtc);
>>>>        if (ret < 0) {
>>>> --
>>>> 1.7.0.4
>>>>
> 
>

Patch

diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
index ed1b868..2715b96 100644
--- a/drivers/rtc/rtc-twl.c
+++ b/drivers/rtc/rtc-twl.c
@@ -475,7 +475,7 @@  static int __devinit twl_rtc_probe(struct platform_device *pdev)
 	if (ret < 0)
 		goto out1;
 
-	ret = request_irq(irq, twl_rtc_interrupt,
+	ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
 				IRQF_TRIGGER_RISING,
 				dev_name(&rtc->dev), rtc);
 	if (ret < 0) {