Message ID | 151851397349.5034.7727532494269075807.stgit@localhost.localdomain |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=virtuozzo.com header.i=@virtuozzo.com header.b="JhK2wRbf"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zgcc65gpwz9sNr for <patchwork-incoming@ozlabs.org>; Tue, 13 Feb 2018 20:26:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934353AbeBMJ02 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Tue, 13 Feb 2018 04:26:28 -0500 Received: from mail-he1eur01on0100.outbound.protection.outlook.com ([104.47.0.100]:59325 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933920AbeBMJ0Y (ORCPT <rfc822;netdev@vger.kernel.org>); Tue, 13 Feb 2018 04:26:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Z8pZuhsR9vQPbI9x2PLBYPDEPFidy/TJWyQgShE6oFI=; b=JhK2wRbfZD1HZuw6zzSUF0hQQGwkWz/OAT0B7z/8QFXn3LIwRQMLJ2iH7XxSS04a9c3ptZ1G2EuRhy7tpL5q/wdw3uil6T/0hPe+zG7Ohv9I26BQcbxCNfe0J3lA/krTrX8f/BrL3JIiCWw1De6yCcCIzGbPZOlUPH1pudtMEfc= Received: from localhost.localdomain (195.214.232.6) by HE1PR0801MB1339.eurprd08.prod.outlook.com (2603:10a6:3:3a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Tue, 13 Feb 2018 09:26:17 +0000 Subject: [PATCH net-next v3 02/32] net: Cleanup in copy_net_ns() From: Kirill Tkhai <ktkhai@virtuozzo.com> To: davem@davemloft.net, vyasevic@redhat.com, kstewart@linuxfoundation.org, pombredanne@nexb.com, vyasevich@gmail.com, mark.rutland@arm.com, gregkh@linuxfoundation.org, adobriyan@gmail.com, fw@strlen.de, nicolas.dichtel@6wind.com, xiyou.wangcong@gmail.com, roman.kapl@sysgo.com, paul@paul-moore.com, dsahern@gmail.com, daniel@iogearbox.net, lucien.xin@gmail.com, mschiffer@universe-factory.net, rshearma@brocade.com, netdev@vger.kernel.org, ktkhai@virtuozzo.com, ebiederm@xmission.com, avagin@virtuozzo.com, gorcunov@virtuozzo.com, eric.dumazet@gmail.com, stephen@networkplumber.org, ktkhai@virtuozzo.com Date: Tue, 13 Feb 2018 12:26:13 +0300 Message-ID: <151851397349.5034.7727532494269075807.stgit@localhost.localdomain> In-Reply-To: <151851357738.5034.10272265431844825686.stgit@localhost.localdomain> References: <151851357738.5034.10272265431844825686.stgit@localhost.localdomain> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR02CA0115.eurprd02.prod.outlook.com (2603:10a6:7:29::44) To HE1PR0801MB1339.eurprd08.prod.outlook.com (2603:10a6:3:3a::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c11d448a-d3db-4e4f-15b9-08d572c3d67b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0801MB1339; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1339; 3:Jsg07VPQV9mmRY8sOCuGuUMtW5o5k0F8WeJSjuKMNEup2FGYCrdpvJ7ZD7U17dlSiXG1Shkrra7sQBUp7WN6ma85A3L1iuiizaB0ECm1x+JgA1e/4XsFDCYkWhYFfgBE71pujv/58wFTBu4ifxmIThDje6zoPy3MPo0+QuMd6juZAYhQbMETL1vK0ZDzt8eCFCPweCfwcl9v6deI7KY0dit6A5VsvEQMeLcId4HCDpPSbxuWVNLMDwlq4ZMwLK6l; 25:XQlN6ZUEBQxAAL/xhotUePpBFv0RluO/ejKlO0y4xkkO1rkuE+pcROZxeJDpyBWTcV3Pj6/Ywix5trIcjnbj5ahA9uMTEBfcTNPDz+qatExh8DeIWv7cEJsCI5oAg7DsiQ34Gtmjt0tUVo/5SiPEYlb2urpptCOYYdsJ5IRUa2LPuhTqRx+Gt4IW4t8R/BFg5CXh8qDVsF/1aJmUhDU6CVenzc+/OUsi3p9Zp0mfqRltvSvu9uGa1g5QDNPm90lEMNUTrqZcU0PmjOQ89ujbdHH4ipTFmJWBBEEY+VgNn/Eyr3Z6OLNP9YQS9fjqp9jT+r+yJZcCIOlKa3Fub1HSEg==; 31:B/t/ZT7MU/0qaAXzQxmzEPG2/xTUyD5oO53VD0oExEZZRO4QND8yO5scqF3HzD7lTjeabLt/5m3kgEO2pBrjd/Oz/fu2T1kTD58JJpepMdbYHe89OE7nU7bUf8e8guy4bQLdCTTurVm5cVmm3JkHqPyDW6y4YFbdzmzPUeK7AANMYEssKXBQK+54DHsSEU8yN8kCNwSschdFhRLDlrFmge9RxwHL/D19c39VSq4CiHQ= X-MS-TrafficTypeDiagnostic: HE1PR0801MB1339: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1339; 20:qZlmED634lv5DlpC21Byf6OXkz5ApaJ9vgBJDI+xnlXCe6LOYe38+LAKPxmlAKA5vQ9LBF/fpkvI+0h5auTP2TMmuilxINVad5qFulbq9u5SlpgojUu30/1xXJp4MG8OdfUn2r16u70Wi20EGZ0+YZ5oPN77m8uAH7u7pYX/S5gde2iWBg9bRj+5/XZepopO2/WOLDczwgwsVu3W/xpthoAidz6Qd9oI14VGOHk05wL2yxM0BPfPO1GJJLLxMpRD8RCcEwq2zwsYh8lhYrfdfsZSqVdJUVJgrtf4CIKcO5QcIR17hca2KyJdupyaP1MI/vW7AIyY8fIDYO6PMSOXw41AK052Ufg/UYv0Nikek9BOPcEFzAk/yLD1y7tjfbpxbYnxskudfGvEottX5BK4UFhuAZfjBE+635EpKU3GkFuHDrQYOled0CrpMKkJLSJpjrsO9+vmXfCHoEKexISn2pQ29Ir8Bv3ETg4NzRk0sV/e3JiHC7Bebaf6rp0oMTqF; 4:GOO+qqhLWw+blGUfjyVIiM7NPitTYFQ6E/a2fMOR3+AKs2cuiaHaLsz7/UHwpye4iC7M712vD/+XD9y7TlvtdDjIIaBKaZw1aKx0SDW1EczZgv1QI/Czzokisrv6ClncbozhrysDfs07ErZZXWMYvBV7TkaonbNjQex8J3FjHk9Q83OxaW+Xb3oU6fNzXuoyeQERDqd+x8iSpOd5rqdFAVBhWCbgseYBImA/qEYCecLbFNmDr1iPLFtLCSY2TJ50t0tGZb4JIG3+errvn3DzCA== X-Microsoft-Antispam-PRVS: <HE1PR0801MB133918248A0E8E5B82ABF29DCDF60@HE1PR0801MB1339.eurprd08.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231101)(2400082)(944501161)(3002001)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0801MB1339; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1339; X-Forefront-PRVS: 0582641F53 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(346002)(376002)(366004)(396003)(39380400002)(39840400004)(199004)(189003)(81156014)(6666003)(5660300001)(186003)(6116002)(83506002)(3846002)(97736004)(16526019)(230700001)(2906002)(8676002)(81166006)(7416002)(478600001)(2950100002)(7736002)(305945005)(53936002)(25786009)(8936002)(316002)(86362001)(39060400002)(58126008)(66066001)(23676004)(59450400001)(106356001)(6506007)(7696005)(2486003)(9686003)(52116002)(386003)(55236004)(47776003)(26005)(55016002)(105586002)(33896004)(61506002)(50466002)(68736007)(6346003)(76176011)(103116003)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0801MB1339; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ktkhai@virtuozzo.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BHE1PR0801MB1339=3B23=3AXd?= =?utf-8?q?EUzATKr6qVwog/5/EyJJCK5X84ju0umpyAvEZclRm1Z+KC7XOkt0RCMU?= =?utf-8?q?F9QfKBZm4CsT23zmJ5Wo7icDghqKUj1BYJMkG6GaLf4fcT5jZiGHtbND?= =?utf-8?q?OvWHes7nwmB2I/ymQ8sU8AavZa9W8CxcKg5jf4zOYvMUN2dXMyyApv2T?= =?utf-8?q?VubdCCoPhyD6VlNL7P/tbuGTzoltW9RPiEj6RHlnEtdMYE69jUdTFWSf?= =?utf-8?q?HelQd9HPI0Rz1R7tMNhKHbZtKCYQ0ikc0/r6qheZe8rAXs5Ua5sHfSoR?= =?utf-8?q?CVoLMSsGkvZ3f3uCsFrYfGBtNlXW7x8IAdT0Qoru80uljZzipkaC86lG?= =?utf-8?q?DHW5l5xEb5EGii21P1myKEdxj+JeYCJWfscB2XmzHCSi9LEixU6n71UJ?= =?utf-8?q?mimTR8s3BAASOBEq7SCc07UIKGSTMSpNqA0/hQGArb0Alr+F+wwPXydU?= =?utf-8?q?DyJ0LbYFs6pj6ROXL5IFQ/3cyy93dI2K1t6W5WyVIfqJmjHOhLkbmiIp?= =?utf-8?q?lEtHCWUpMTxdykqR3vTCCVus+HBxz2plBgjj7GFOh8YKSKVAV9NrdUyY?= =?utf-8?q?EZfsHqv4CGq0JvTk4CZ3j7EDUsoI6/9HG/LV9yGkAUujiyVHc1bARp0T?= =?utf-8?q?5rdGdplCyEuKZZuWwnUqenVvpiDTSo1/LOSW6kmW8S71C+wevfjH3ztn?= =?utf-8?q?BV1sETaSWhRGTHw3BLsp0Ieadr7VREggLna3Zlxw0cMgQ5L1J1gfrOW7?= =?utf-8?q?dha6koAaySrjEPlrMODBd+MSzqWQAx/f2GPlETJBITvIAX93aB/iihtw?= =?utf-8?q?TvEY3U7hfTb35pAWkQFKOszI8vfgK9Me/xs+8LrcRNa1pOqfElsHoA97?= =?utf-8?q?soHIIDnGC10LGcpBUEX8n2oBn774Igo5o7IUMNMzsrV66QfPC/JdDxLc?= =?utf-8?q?aJVnsczHywkaLUwh2E81mYQXRexVIgpUWnYSLNpFR2nweFhfV543QQfm?= =?utf-8?q?tDZmBarFhvGoZuy2raAc2jRhVlgpBqzoAR8PpTk/PRG1hOknp9ZJmAkH?= =?utf-8?q?s8XDeM65aMXaN21L045U0dG7+7TTuNbwIdGFvqVYoVDLHGWHuxDI7J1u?= =?utf-8?q?vEDfe8uGwuxxVZJB5kCbLCv/oHwPtawPTYfQXlkly9Sg0KCiXqfkw+e2?= =?utf-8?q?fYD9YLw+c5gnL2PcnD8JGvP/6YLW0vI1frYhOpuo6tsScZ9e2EsrAx9x?= =?utf-8?q?Asllg9xEHZCI49RKeRxOCwp7xC6O+bOH2n83+tRoGHbca7FXBDm8QL2f?= =?utf-8?q?0izo54pg2kwolKHq19kbsVaNKgJykjOc6UDtFhRWfsafHYTlmUHXJorl?= =?utf-8?q?QwQFobVg3XNlL5rVmgcke0zooAcsM+Ce4=3D?= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1339; 6:szw7JndoEbYRtsQK6zDULyiS6+xHRUbkE7gVk4HWZn4U6GOj/l/4TutO2O5oR3UiggbIClF6/bd9UMMXoMMhgw1lzT54aUKwB+6l/k2aq4oj1BMOuHfZ+dNzuDu4EPjf3ndryqeyWDQcXk9/giWq6OU5BDmymF3hbv6/AiBvSfHFjwVf7yRA12e7ZQYn65VcQgZ3WYITdH8Gto74CMMrojU+oUNUk+6YXirmjIVbPTCsPlQxmnEXp8fgwGyW84Iv1vops0Eg4meYRCyv7WNwoc8yqClTgalkm333Ej83SIi7KI8Zt6vH5i2AYnw15abI2zwT4MUrmatbv3nXoL6TQAHoWvCJ4PqN0vXUIc7n1OA=; 5:yYNMQfxZ5NjtuvzVNBO4C0yMoCV4/z7ZNdeFi/SFY2vTmWdi3ZByQ9yhaYMsFWIcHZ0ori3L5eDEjz6Kz3FwDlP3evbloCPWPb+0UiD9kuQHC1NmXQDMfggtvLyF4+Wi9h3ZsB9I8pTXOmV1UjizfgorKltYsbB+mNEmk9blMZs=; 24:rl1W2XaQy5TfcYiCtI6+2Am8PkQi+AXSclUwbJAMpvKx6Ucd0ZD7904XQFXD0ziYMWuRohoLJw3XQ6YvlZBqyxCtF5s6bnwWz9YLxEDFKRI=; 7:l418wP/PVPnnSRdO7UBJxExkTt/bEoueF5mSlL2iCUApnUkl6Viy91EvFUMu5bG8cvr4AHtuOF5+Q1hx1gHina2IPH34DEYvxWybWhVSX8erXVZJxebQNQdpnp7J2pl3Ba35QnKvoJTiDD1dMBz2sF8s2PX/4/v3M3PlCvYKJzryz0GfD+kHBBSk1sk2JR7VPudCJKjnPbpI4ieKUP5LIbIdIsqw7075gw3WE8tARqTNVlJPdvm24mjSuxZDodf8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR0801MB1339; 20:LeR/pfB3S0vALoNRXYn84ZnS0LqtG46LYnMy1dSRICwTc7qkkKb131hguay2VnR0sWNo8KqnyrNbq+Ru6uAehSvGaZBiPiqyLajGOJGeINZp6rij82vW8ZYiQ9b8I/4YlXyu49hnTP/de+AlkGLxw5ufu70N+NKYIj9jP5jrBM0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2018 09:26:17.7716 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c11d448a-d3db-4e4f-15b9-08d572c3d67b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1339 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
Replacing net_mutex with rw_semaphore
|
expand
|
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 1180c217895a..81384386f91b 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -411,27 +411,25 @@ struct net *copy_net_ns(unsigned long flags, net = net_alloc(); if (!net) { - dec_net_namespaces(ucounts); - return ERR_PTR(-ENOMEM); + rv = -ENOMEM; + goto dec_ucounts; } - + refcount_set(&net->passive, 1); + net->ucounts = ucounts; get_user_ns(user_ns); rv = mutex_lock_killable(&net_mutex); - if (rv < 0) { - net_free(net); - dec_net_namespaces(ucounts); - put_user_ns(user_ns); - return ERR_PTR(rv); - } + if (rv < 0) + goto put_userns; - net->ucounts = ucounts; rv = setup_net(net, user_ns); mutex_unlock(&net_mutex); if (rv < 0) { - dec_net_namespaces(ucounts); +put_userns: put_user_ns(user_ns); net_drop_ns(net); +dec_ucounts: + dec_net_namespaces(ucounts); return ERR_PTR(rv); } return net;