[U-Boot] cmd: booti: fix invalid image address in debug message

Message ID 1518491403-8352-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] cmd: booti: fix invalid image address in debug message
Related show

Commit Message

Masahiro Yamada Feb. 13, 2018, 3:10 a.m.
With commit 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c"),
images->ep has not been set at this point.

Fixes: 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 cmd/booti.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bin Chen Feb. 13, 2018, 10:35 a.m. | #1
On 13 February 2018 at 14:10, Masahiro Yamada <yamada.masahiro@socionext.com
> wrote:

> With commit 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c"),
> images->ep has not been set at this point.
>
> Fixes: 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  cmd/booti.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cmd/booti.c b/cmd/booti.c
> index 0be786c..fff9369 100644
> --- a/cmd/booti.c
> +++ b/cmd/booti.c
> @@ -37,8 +37,7 @@ static int booti_start(cmd_tbl_t *cmdtp, int flag, int
> argc,
>                                 load_addr);
>         } else {
>                 ld = simple_strtoul(argv[0], NULL, 16);
> -               debug("*  kernel: cmdline image address = 0x%08lx\n",
> -                       images->ep);
> +               debug("*  kernel: cmdline image address = 0x%08lx\n", ld);
>         }
>
>         ret = booti_setup(ld, &relocated_addr, &image_size);
>

Reviewed-by: Bin Chen <bin.chen@linaro.org>


> --
> 2.7.4
>
>
Tom Rini Feb. 14, 2018, 4:43 p.m. | #2
On Tue, Feb 13, 2018 at 12:10:02PM +0900, Masahiro Yamada wrote:

> With commit 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c"),
> images->ep has not been set at this point.
> 
> Fixes: 6808ef9ac2a6 ("move booti_setup to arch/arm/lig/image.c")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: Bin Chen <bin.chen@linaro.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/cmd/booti.c b/cmd/booti.c
index 0be786c..fff9369 100644
--- a/cmd/booti.c
+++ b/cmd/booti.c
@@ -37,8 +37,7 @@  static int booti_start(cmd_tbl_t *cmdtp, int flag, int argc,
 				load_addr);
 	} else {
 		ld = simple_strtoul(argv[0], NULL, 16);
-		debug("*  kernel: cmdline image address = 0x%08lx\n",
-			images->ep);
+		debug("*  kernel: cmdline image address = 0x%08lx\n", ld);
 	}
 
 	ret = booti_setup(ld, &relocated_addr, &image_size);