[U-Boot] mmc: Drop unnecessary case for mmc_probe()

Message ID 1518444324-11889-1-git-send-email-faiz_abbas@ti.com
State Accepted
Delegated to: Jaehoon Chung
Headers show
Series
  • [U-Boot] mmc: Drop unnecessary case for mmc_probe()
Related show

Commit Message

Faiz Abbas Feb. 12, 2018, 2:05 p.m.
Drop the unnecessary empty function case for mmc_probe().

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
 drivers/mmc/mmc.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Faiz Abbas Feb. 19, 2018, 5:31 a.m. | #1
Hi,

On Monday 12 February 2018 07:35 PM, Faiz Abbas wrote:
> Drop the unnecessary empty function case for mmc_probe().
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
>  drivers/mmc/mmc.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 255310a..e0b9a42 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2657,12 +2657,7 @@ void mmc_set_preinit(struct mmc *mmc, int preinit)
>  	mmc->preinit = preinit;
>  }
>  
> -#if CONFIG_IS_ENABLED(DM_MMC) && defined(CONFIG_SPL_BUILD)
> -static int mmc_probe(bd_t *bis)
> -{
> -	return 0;
> -}
> -#elif CONFIG_IS_ENABLED(DM_MMC)
> +#if CONFIG_IS_ENABLED(DM_MMC)
>  static int mmc_probe(bd_t *bis)
>  {
>  	int ret, i;
> 

Gentle ping.

Thanks,
Faiz
Jaehoon Chung Feb. 23, 2018, 7:01 a.m. | #2
On 02/19/2018 02:31 PM, Faiz Abbas wrote:
> Hi,
> 
> On Monday 12 February 2018 07:35 PM, Faiz Abbas wrote:
>> Drop the unnecessary empty function case for mmc_probe().
>>
>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

Applied to u-boot-mmc.

Best Regards,
Jaehoon Chung

>> ---
>>  drivers/mmc/mmc.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 255310a..e0b9a42 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -2657,12 +2657,7 @@ void mmc_set_preinit(struct mmc *mmc, int preinit)
>>  	mmc->preinit = preinit;
>>  }
>>  
>> -#if CONFIG_IS_ENABLED(DM_MMC) && defined(CONFIG_SPL_BUILD)
>> -static int mmc_probe(bd_t *bis)
>> -{
>> -	return 0;
>> -}
>> -#elif CONFIG_IS_ENABLED(DM_MMC)
>> +#if CONFIG_IS_ENABLED(DM_MMC)
>>  static int mmc_probe(bd_t *bis)
>>  {
>>  	int ret, i;
>>
> 
> Gentle ping.
> 
> Thanks,
> Faiz
> 
> 
>

Patch

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 255310a..e0b9a42 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -2657,12 +2657,7 @@  void mmc_set_preinit(struct mmc *mmc, int preinit)
 	mmc->preinit = preinit;
 }
 
-#if CONFIG_IS_ENABLED(DM_MMC) && defined(CONFIG_SPL_BUILD)
-static int mmc_probe(bd_t *bis)
-{
-	return 0;
-}
-#elif CONFIG_IS_ENABLED(DM_MMC)
+#if CONFIG_IS_ENABLED(DM_MMC)
 static int mmc_probe(bd_t *bis)
 {
 	int ret, i;