From patchwork Mon Feb 12 14:01:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 872088 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b="weUJy0aV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zg6ml6JZzz9sNw for ; Tue, 13 Feb 2018 01:02:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbeBLOCO (ORCPT ); Mon, 12 Feb 2018 09:02:14 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:40930 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630AbeBLOCN (ORCPT ); Mon, 12 Feb 2018 09:02:13 -0500 Received: by mail-pl0-f65.google.com with SMTP id g18so5046677plo.7 for ; Mon, 12 Feb 2018 06:02:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=0LMLS3Nq2Gp7ufIsPidlvTRp+TtJnaGRljBW9iQRTvs=; b=weUJy0aVjAwMCw332QW60y88YqGndx0afrCx2iNUl4yzhc4OQybZWf/eVCPRI6YSmp bIJq8LXCc2U36wPkFK2Xe5T9yAAI7oYwmSpGBrvwtRISKFMG+d1wDxAEIpxz6I5KzD96 Gb3UtxesP+CR4qhfCWZhF/2NTKzuXH29SSCbriDqVJBAX7fy/+5k/oaqBaidh7bhUWSX tynKit3VInksGTtVJN1Xvpk58gtg3Bkkn5ZjhBZUsyj5JfPkhQgIYh1AI36P3PQrkCVl 4OLYDQP7XIUUq4hwn0N3zcSTz19PkPSB6+QS040R5JLupzvCkHm1ImmOMgUaY9zCYGdw R6eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0LMLS3Nq2Gp7ufIsPidlvTRp+TtJnaGRljBW9iQRTvs=; b=r7dU31O3wgkbERYwIK0E2iEG/WcAC8fi6dhHnSBbWUGYHOsffxlmlWknPXpWiNYHs0 3c9PSOGJ74s1Khz1n1Rb6MDO00vYOyjtYjw1m+2fFfAe69DcluCC1QulMrFnrS3gfI5n /Sd0DiIJUOc87hVEoV3GYFVZ+ADdh2QFfYFuA/gOPbTb+ukeeir5ChOXYgggxZgFZN1d Y8wsqyAx+NzznzINY5L9tNNuaeNmpNSr6D/pGG80XH/B/Ln9tXVpjfjKmKSTY12/5FKl fnfbFLeqoqqu5EQirrJyTjtmMJajZAlIcmBqpgtxQt/fCLqW+aaBWsjqRW/bTZSXCbba pYwQ== X-Gm-Message-State: APf1xPAxgK+9L9KNghUCIjpVdalKhRVNc9OF0BRNnZk1oRbIgOXsvf8f oPUmmTMrykt1PuB3Q8VMqhtJPA== X-Google-Smtp-Source: AH8x224IcM8U4LkhDSgFkRRB6FyBlW7BchYB99v6XylIsURR+eQgtJx2Bc4bYUvvi9uQa+c5WXXCtg== X-Received: by 2002:a17:902:7688:: with SMTP id m8-v6mr10007226pll.241.1518444132924; Mon, 12 Feb 2018 06:02:12 -0800 (PST) Received: from localhost.localdomain (36-239-221-14.dynamic-ip.hinet.net. [36.239.221.14]) by smtp.gmail.com with ESMTPSA id q2sm17934604pgf.10.2018.02.12.06.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2018 06:02:11 -0800 (PST) From: Axel Lin To: Linus Walleij Cc: Thierry Reding , Jonathan Hunter , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, Axel Lin Subject: [PATCH] gpio: tegra: Convert to use DEFINE_SHOW_ATTRIBUTE macro Date: Mon, 12 Feb 2018 22:01:57 +0800 Message-Id: <20180212140157.27023-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.14.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Axel Lin --- drivers/gpio/gpio-tegra.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 02fa8fe2292a..94396caaca75 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -506,7 +506,7 @@ static int tegra_gpio_irq_set_wake(struct irq_data *d, unsigned int enable) #include #include -static int dbg_gpio_show(struct seq_file *s, void *unused) +static int tegra_dbg_gpio_show(struct seq_file *s, void *unused) { struct tegra_gpio_info *tgi = s->private; unsigned int i, j; @@ -530,22 +530,12 @@ static int dbg_gpio_show(struct seq_file *s, void *unused) return 0; } -static int dbg_gpio_open(struct inode *inode, struct file *file) -{ - return single_open(file, dbg_gpio_show, inode->i_private); -} - -static const struct file_operations debug_fops = { - .open = dbg_gpio_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(tegra_dbg_gpio); static void tegra_gpio_debuginit(struct tegra_gpio_info *tgi) { (void) debugfs_create_file("tegra_gpio", 0444, - NULL, tgi, &debug_fops); + NULL, tgi, &tegra_dbg_gpio_fops); } #else