| Message ID | d73420c9-60ee-ab28-e881-299441815afc@users.sourceforge.net |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: merrifield: Delete an error message for a failed memory allocation in mrfld_gpio_probe() | expand |
On Sun, 2018-02-11 at 13:42 +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 11 Feb 2018 13:30:14 +0100 > > Omit an extra message for a memory allocation failure in this > function. > > This issue was detected by using the Coccinelle software. > Linus, I have no strong opinion here, so, up to you to decide. If you decide this patch to go, Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/gpio/gpio-merrifield.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio- > merrifield.c > index dd67a31ac337..eec21122299e 100644 > --- a/drivers/gpio/gpio-merrifield.c > +++ b/drivers/gpio/gpio-merrifield.c > @@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, > const struct pci_device_id *id > pcim_iounmap_regions(pdev, BIT(1)); > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > - if (!priv) { > - dev_err(&pdev->dev, "can't allocate chip data\n"); > + if (!priv) > return -ENOMEM; > - } > > priv->dev = &pdev->dev; > priv->reg_base = pcim_iomap_table(pdev)[0];
On Sun, Feb 11, 2018 at 1:42 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 11 Feb 2018 13:30:14 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c index dd67a31ac337..eec21122299e 100644 --- a/drivers/gpio/gpio-merrifield.c +++ b/drivers/gpio/gpio-merrifield.c @@ -408,10 +408,8 @@ static int mrfld_gpio_probe(struct pci_dev *pdev, const struct pci_device_id *id pcim_iounmap_regions(pdev, BIT(1)); priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "can't allocate chip data\n"); + if (!priv) return -ENOMEM; - } priv->dev = &pdev->dev; priv->reg_base = pcim_iomap_table(pdev)[0];