diff mbox series

[U-Boot,v2,2/2] disk: part: use common api to lookup part driver

Message ID 1518256538-28690-2-git-send-email-kever.yang@rock-chips.com
State Accepted
Delegated to: Tom Rini
Headers show
Series [U-Boot,v2,1/2] disk: part: scan the disk if the part_type is unknown | expand

Commit Message

Kever Yang Feb. 10, 2018, 9:55 a.m. UTC 
Do not need to scan disk every time when we get part info
by name.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2:
- rebase to latest version
- add error handle for partition tbale not exist

 disk/part.c | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

Comments

Tom Rini March 14, 2018, 2:09 p.m. UTC | #1 
On Sat, Feb 10, 2018 at 05:55:38PM +0800, Kever Yang wrote:

> Do not need to scan disk every time when we get part info
> by name.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/disk/part.c b/disk/part.c
index df0d50d..b80a4b1 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -644,28 +644,25 @@  cleanup:
 int part_get_info_by_name_type(struct blk_desc *dev_desc, const char *name,
 			       disk_partition_t *info, int part_type)
 {
-	struct part_driver *first_drv =
-		ll_entry_start(struct part_driver, part_driver);
-	const int n_drvs = ll_entry_count(struct part_driver, part_driver);
 	struct part_driver *part_drv;
-
-	for (part_drv = first_drv; part_drv != first_drv + n_drvs; part_drv++) {
-		int ret;
-		int i;
-		for (i = 1; i < part_drv->max_entries; i++) {
-			if (part_type >= 0 && part_type != part_drv->part_type)
-				break;
-			ret = part_drv->get_info(dev_desc, i, info);
-			if (ret != 0) {
-				/* no more entries in table */
-				break;
-			}
-			if (strcmp(name, (const char *)info->name) == 0) {
-				/* matched */
-				return i;
-			}
+	int ret;
+	int i;
+
+	part_drv = part_driver_lookup_type(dev_desc);
+	if (!part_drv)
+		return -1;
+	for (i = 1; i < part_drv->max_entries; i++) {
+		ret = part_drv->get_info(dev_desc, i, info);
+		if (ret != 0) {
+			/* no more entries in table */
+			break;
+		}
+		if (strcmp(name, (const char *)info->name) == 0) {
+			/* matched */
+			return i;
 		}
 	}
+
 	return -1;
 }