Patchwork UBUNTU: Include nls_cp437 module in virtual for fat

login
register
mail settings
Submitter Loïc Minier
Date March 16, 2011, 12:49 a.m.
Message ID <1300236577-20635-1-git-send-email-loic.minier@linaro.org>
Download mbox | patch
Permalink /patch/87138/
State New
Headers show

Comments

Loïc Minier - March 16, 2011, 12:49 a.m.
The virtual flavor only ships whitelisted modules including the fat and
vfat modules, but because it doesn't include any codepage modules
(nls_cp*) FAT support is useless.  Include the default codepage
(nls_cp437) in virtual to allow mounting FAT filesystems.

BugLink: http://bugs.launchpad.net/bugs/735240

Signed-off-by: Loïc Minier <loic.minier@linaro.org>
---
 debian.master/control.d/virtual.inclusion-list |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Tim Gardner - March 16, 2011, 1:52 p.m.
On 03/15/2011 06:49 PM, Loïc Minier wrote:
> The virtual flavor only ships whitelisted modules including the fat and
> vfat modules, but because it doesn't include any codepage modules
> (nls_cp*) FAT support is useless.  Include the default codepage
> (nls_cp437) in virtual to allow mounting FAT filesystems.
>
> BugLink: http://bugs.launchpad.net/bugs/735240
>
> Signed-off-by: Loïc Minier<loic.minier@linaro.org>
> ---
>   debian.master/control.d/virtual.inclusion-list |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/debian.master/control.d/virtual.inclusion-list b/debian.master/control.d/virtual.inclusion-list
> index 043d576..e2b529c 100644
> --- a/debian.master/control.d/virtual.inclusion-list
> +++ b/debian.master/control.d/virtual.inclusion-list
> @@ -86,6 +86,7 @@ fs/btrfs/*
>   fs/configfs/*
>   fs/exportfs/*
>   fs/fat/*
> +fs/nls/nls_cp437.ko
>   fs/isofs/*
>   fs/cifs/*
>   fs/xfs/*

Acked-by: Tim Gardner <tim.gardner@canonical.com> for Maverick and Natty
Andy Whitcroft - March 16, 2011, 2:31 p.m.
On Wed, Mar 16, 2011 at 01:49:37AM +0100, Loïc Minier wrote:
> The virtual flavor only ships whitelisted modules including the fat and
> vfat modules, but because it doesn't include any codepage modules
> (nls_cp*) FAT support is useless.  Include the default codepage
> (nls_cp437) in virtual to allow mounting FAT filesystems.
> 
> BugLink: http://bugs.launchpad.net/bugs/735240

BugLink: http://bugs.launchpad.net/bugs/732046

> Signed-off-by: Loïc Minier <loic.minier@linaro.org>
> ---
>  debian.master/control.d/virtual.inclusion-list |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/debian.master/control.d/virtual.inclusion-list b/debian.master/control.d/virtual.inclusion-list
> index 043d576..e2b529c 100644
> --- a/debian.master/control.d/virtual.inclusion-list
> +++ b/debian.master/control.d/virtual.inclusion-list
> @@ -86,6 +86,7 @@ fs/btrfs/*
>  fs/configfs/*
>  fs/exportfs/*
>  fs/fat/*
> +fs/nls/nls_cp437.ko
>  fs/isofs/*
>  fs/cifs/*
>  fs/xfs/*

I suspect this should be in alphabetical order.  (Both of the these can
be fixed as this is applied, no need to resend.)

I am inclined to say that if fat is useless without at least this code
page, that it is worth including otherwise you cannot mount install media
within a virtual instance.  So it seems appropriate to pull this in for
Natty.

-apw
Tim Gardner - March 16, 2011, 2:41 p.m.
On 03/15/2011 06:49 PM, Loïc Minier wrote:
> The virtual flavor only ships whitelisted modules including the fat and
> vfat modules, but because it doesn't include any codepage modules
> (nls_cp*) FAT support is useless.  Include the default codepage
> (nls_cp437) in virtual to allow mounting FAT filesystems.
>
> BugLink: http://bugs.launchpad.net/bugs/735240
>
> Signed-off-by: Loïc Minier<loic.minier@linaro.org>
> ---
>   debian.master/control.d/virtual.inclusion-list |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/debian.master/control.d/virtual.inclusion-list b/debian.master/control.d/virtual.inclusion-list
> index 043d576..e2b529c 100644
> --- a/debian.master/control.d/virtual.inclusion-list
> +++ b/debian.master/control.d/virtual.inclusion-list
> @@ -86,6 +86,7 @@ fs/btrfs/*
>   fs/configfs/*
>   fs/exportfs/*
>   fs/fat/*
> +fs/nls/nls_cp437.ko
>   fs/isofs/*
>   fs/cifs/*
>   fs/xfs/*

applied (with commit log fixes for bug number) to Maverick and Natty
Loïc Minier - March 16, 2011, 3:07 p.m.
On Wed, Mar 16, 2011, Andy Whitcroft wrote:
> I suspect this should be in alphabetical order.  (Both of the these can
> be fixed as this is applied, no need to resend.)

 Yup, but as the list wasn't sorted I did the nls addition just after
 the fat modules.

> I am inclined to say that if fat is useless without at least this code
> page, that it is worth including otherwise you cannot mount install media
> within a virtual instance.  So it seems appropriate to pull this in for
> Natty.

 If you're tempted to include it there, it also affects maverick.

Patch

diff --git a/debian.master/control.d/virtual.inclusion-list b/debian.master/control.d/virtual.inclusion-list
index 043d576..e2b529c 100644
--- a/debian.master/control.d/virtual.inclusion-list
+++ b/debian.master/control.d/virtual.inclusion-list
@@ -86,6 +86,7 @@  fs/btrfs/*
 fs/configfs/*
 fs/exportfs/*
 fs/fat/*
+fs/nls/nls_cp437.ko
 fs/isofs/*
 fs/cifs/*
 fs/xfs/*