Add check before potentially dividing by 0

Submitter	asharif
Date	March 16, 2011, 12:45 a.m.
Message ID	<AANLkTimphyNTTAvxNgiceJ263O5xgOeuSjbuKsSvApvL@mail.gmail.com>
Download	mbox \| patch
Permalink	/patch/87137/
State	New
Headers	show Return-Path: <gcc-patches-return-286963-incoming=patchwork.ozlabs.org@gcc.gnu.org> MIME-Version: 1.0 In-Reply-To: <AANLkTinbOe+ozP62SoctrOp3td=2SDK3wCyBiw3MNYf=@mail.gmail.com> References: <AANLkTinbOe+ozP62SoctrOp3td=2SDK3wCyBiw3MNYf=@mail.gmail.com> From: asharif <asharif@gcc.gnu.org> Date: Tue, 15 Mar 2011 17:45:27 -0700 Message-ID: <AANLkTimphyNTTAvxNgiceJ263O5xgOeuSjbuKsSvApvL@mail.gmail.com> Subject: Re: [PATCH] Add check before potentially dividing by 0 To: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org

Comments

asharif - March 16, 2011, 12:45 a.m.

I have seen an ICE in 4.4.3 when a corrupted profile file causes a
division by 0 in gcc. This is the equivalent code in trunk and this
check should help fix it.
Thoughts?

2011-03-15  Ahmad Sharif  <asharif@google.com>

       * predict.c (probably_never_executed_bb_p): Add check to see
       whether profile_info->runs is equal to 0 before doing the division.
NODE_FREQUENCY_UNLIKELY_EXECUTED)

Patch

Index: predict.c
===================================================================
--- predict.c (revision 171019)
+++ predict.c (working copy)
@@ -200,7 +200,7 @@ 
 bool
 probably_never_executed_bb_p (const_basic_block bb)
 {
-  if (profile_info && flag_branch_probabilities)
+  if (profile_info && flag_branch_probabilities && profile_info->runs != 0)
     return ((bb->count + profile_info->runs / 2) / profile_info->runs) == 0;
   if ((!profile_info || !flag_branch_probabilities)
       && cgraph_node (current_function_decl)->frequency ==

Patchwork Add check before potentially dividing by 0

Comments

Patch