From patchwork Tue Mar 15 23:34:16 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Benjamin Kosnik <bkoz@redhat.com>
X-Patchwork-Id: 87126
Return-Path: 
 <gcc-patches-return-286958-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id 8E81CB7045
	for <incoming@patchwork.ozlabs.org>;
	Wed, 16 Mar 2011 10:34:37 +1100 (EST)
Received: (qmail 27944 invoked by alias); 15 Mar 2011 23:34:33 -0000
Received: (qmail 27717 invoked by uid 22791); 15 Mar 2011 23:34:31 -0000
X-SWARE-Spam-Status: No, hits=-5.8 required=5.0	tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by
	sourceware.org (qpsmtpd/0.43rc1) with ESMTP;
	Tue, 15 Mar 2011 23:34:19 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by
	mx1.redhat.com (8.14.4/8.14.4) with ESMTP id
	p2FNYHUA012214	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA
	bits=256 verify=OK); Tue, 15 Mar 2011 19:34:17 -0400
Received: from shotwell (ovpn-113-58.phx2.redhat.com [10.3.113.58])	by
	int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4)
	with ESMTP id p2FNYGQK028407	(version=TLSv1/SSLv3
	cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
	Tue, 15 Mar 2011 19:34:17 -0400
Date: Tue, 15 Mar 2011 16:34:16 -0700
From: Benjamin Kosnik <bkoz@redhat.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [v3] typeinfo tuning
Message-ID: <20110315163416.49c68fec@shotwell>
In-Reply-To: <AANLkTikMvUQNzgjujpkbHqYueY333ATN6mEJqtxptG4=@mail.gmail.com>
References: <20110314102944.565db3c8@shotwell>
	<AANLkTin+VKWxyFFBYBAMzDhCTgcQFnkhKydrRTUtQA6n@mail.gmail.com>
	<20110315121944.4dda54e0@shotwell>
	<AANLkTikMvUQNzgjujpkbHqYueY333ATN6mEJqtxptG4=@mail.gmail.com>
Mime-Version: 1.0
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

Like so.

-benjamin

2011-03-15  Benjamin Kosnik  <bkoz@redhat.com>

	* include/std/thread: Revert.
	* src/thread.cc: Same.
	* config/abi/pre/gnu.ver: Same.

Index: src/thread.cc
===================================================================
--- src/thread.cc	(revision 171019)
+++ src/thread.cc	(working copy)
@@ -54,8 +54,6 @@
 
 _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
-  thread::_Impl_base::~_Impl_base() = default;
-
   void
   thread::join()
   {
Index: include/std/thread
===================================================================
--- include/std/thread	(revision 171019)
+++ include/std/thread	(working copy)
@@ -100,7 +100,7 @@
     {
       __shared_base_type	_M_this_ptr;
 
-      virtual ~_Impl_base();
+      inline virtual ~_Impl_base();
 
       virtual void _M_run() = 0;
     };
@@ -195,6 +195,8 @@
       }
   };
 
+  inline thread::_Impl_base::~_Impl_base() = default;
+
   inline void
   swap(thread& __x, thread& __y)
   { __x.swap(__y); }
Index: config/abi/pre/gnu.ver
===================================================================
--- config/abi/pre/gnu.ver	(revision 171019)
+++ config/abi/pre/gnu.ver	(working copy)
@@ -1255,11 +1255,6 @@
     _ZTSNSt13__future_base11_State_baseE;
     _ZTVNSt13__future_base11_State_baseE;
 
-    _ZNSt6thread10_Impl_baseD*;
-    _ZTINSt6thread10_Impl_baseE;
-    _ZTSNSt6thread10_Impl_baseE;
-    _ZTVNSt6thread10_Impl_baseE;
-
 } GLIBCXX_3.4.14;
 
 # Symbols in the support library (libsupc++) have their own tag.