[4/6] ARM: dts: stm32: add MFX support on I2C1 on stm32746g-eval

Message ID 1518100057-23234-5-git-send-email-amelie.delaunay@st.com
State New
Headers show
Series
  • Introduce STMicroelectronics MultiFunction eXpander
Related show

Commit Message

Amelie DELAUNAY Feb. 8, 2018, 2:27 p.m.
MFX is used as gpio expander on stm32746g-eval.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 arch/arm/boot/dts/stm32746g-eval.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Linus Walleij Feb. 22, 2018, 1:54 p.m. | #1
On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@st.com> wrote:

> MFX is used as gpio expander on stm32746g-eval.
>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>

(...)
> +       mfx: mfx@42 {
> +               compatible = "st,mfx";
> +               reg = <0x42>;
> +               interrupts = <8 1>;
> +               interrupt-parent = <&gpioi>;
> +               interrupt-controller;
> +               #interrupt-cells = <1>;
> +
> +               mfxgpio: mfx_gpio {
> +                       compatible = "st,mfx-gpio";
> +                       interrupts = <0>;
> +                       interrupt-parent = <&mfx>;
> +                       gpio-controller;
> +                       #gpio-cells = <2>;

So I think this node should contain some pin config states
that can  be referenced by the drivers to set up push/pull
etc. Probably it can use just standard pin config properties
like sx150x.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Amelie DELAUNAY Feb. 22, 2018, 3:34 p.m. | #2
On 02/22/2018 02:54 PM, Linus Walleij wrote:
> On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@st.com> wrote:

> 

>> MFX is used as gpio expander on stm32746g-eval.

>>

>> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>

> 

> (...)

>> +       mfx: mfx@42 {

>> +               compatible = "st,mfx";

>> +               reg = <0x42>;

>> +               interrupts = <8 1>;

>> +               interrupt-parent = <&gpioi>;

>> +               interrupt-controller;

>> +               #interrupt-cells = <1>;

>> +

>> +               mfxgpio: mfx_gpio {

>> +                       compatible = "st,mfx-gpio";

>> +                       interrupts = <0>;

>> +                       interrupt-parent = <&mfx>;

>> +                       gpio-controller;

>> +                       #gpio-cells = <2>;

> 

> So I think this node should contain some pin config states

> that can  be referenced by the drivers to set up push/pull

> etc. Probably it can use just standard pin config properties

> like sx150x.

> 


I will check that point.

Regards,
Amelie

> Yours,

> Linus Walleij

>

Patch

diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts
index e74ae59..99739f7 100644
--- a/arch/arm/boot/dts/stm32746g-eval.dts
+++ b/arch/arm/boot/dts/stm32746g-eval.dts
@@ -128,6 +128,23 @@ 
 	i2c-scl-rising-time-ns = <185>;
 	i2c-scl-falling-time-ns = <20>;
 	status = "okay";
+
+	mfx: mfx@42 {
+		compatible = "st,mfx";
+		reg = <0x42>;
+		interrupts = <8 1>;
+		interrupt-parent = <&gpioi>;
+		interrupt-controller;
+		#interrupt-cells = <1>;
+
+		mfxgpio: mfx_gpio {
+			compatible = "st,mfx-gpio";
+			interrupts = <0>;
+			interrupt-parent = <&mfx>;
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+	};
 };
 
 &mac {