pinctrl: ocelot: make function ocelot_pinctrl_probe static

Message ID 20180208142437.11217-1-colin.king@canonical.com
State New
Headers show
Series
  • pinctrl: ocelot: make function ocelot_pinctrl_probe static
Related show

Commit Message

Colin King Feb. 8, 2018, 2:24 p.m.
From: Colin Ian King <colin.king@canonical.com>

The function ocelot_pinctrl_probe is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
drivers/pinctrl/pinctrl-ocelot.c:465:5: warning: symbol
'ocelot_pinctrl_probe' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/pinctrl/pinctrl-ocelot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Feb. 22, 2018, 1:02 p.m. | #1
On Thu, Feb 8, 2018 at 3:24 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The function ocelot_pinctrl_probe is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/pinctrl/pinctrl-ocelot.c:465:5: warning: symbol
> 'ocelot_pinctrl_probe' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
index 01a50d969111..a9423238471e 100644
--- a/drivers/pinctrl/pinctrl-ocelot.c
+++ b/drivers/pinctrl/pinctrl-ocelot.c
@@ -462,7 +462,7 @@  static const struct of_device_id ocelot_pinctrl_of_match[] = {
 	{},
 };
 
-int ocelot_pinctrl_probe(struct platform_device *pdev)
+static int ocelot_pinctrl_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct ocelot_pinctrl *info;