patchwork: Get rid of dummy URL for test results
diff mbox series

Message ID 20180208032555.12770-1-andrew.donnellan@au1.ibm.com
State Superseded
Headers show
Series
  • patchwork: Get rid of dummy URL for test results
Related show

Commit Message

Andrew Donnellan Feb. 8, 2018, 3:25 a.m. UTC
At some point, Patchwork didn't like it when we submitted a Check without a
target_url attached, so we sent "no.url" as a default.

That appears to have changed, so get rid of the dummy URL.

Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

---

applies on top of current patchwork series, completely untested
---
 src/patchwork.rs | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andrew Donnellan Feb. 8, 2018, 4:29 a.m. UTC | #1
On 08/02/18 14:25, Andrew Donnellan wrote:
> At some point, Patchwork didn't like it when we submitted a Check without a
> target_url attached, so we sent "no.url" as a default.
> 
> That appears to have changed, so get rid of the dummy URL.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> 
> ---
> 
> applies on top of current patchwork series, completely untested

Or maybe it doesn't! v2 incoming

> ---
>   src/patchwork.rs | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/src/patchwork.rs b/src/patchwork.rs
> index 1aec0d4c7c8f..afbfb07774fa 100644
> --- a/src/patchwork.rs
> +++ b/src/patchwork.rs
> @@ -146,9 +146,6 @@ pub struct TestResult {
>   impl TestResult {
>       pub fn as_json(&self) -> String {
>           let mut result = self.clone();
> -        if result.target_url.is_none() {
> -            result.target_url = Some("http://no.url".to_string());
> -        }
>           if result.context.is_none() {
>               result.context = Some(format!("{}-{}",
>                                        env!("CARGO_PKG_NAME"),
>

Patch
diff mbox series

diff --git a/src/patchwork.rs b/src/patchwork.rs
index 1aec0d4c7c8f..afbfb07774fa 100644
--- a/src/patchwork.rs
+++ b/src/patchwork.rs
@@ -146,9 +146,6 @@  pub struct TestResult {
 impl TestResult {
     pub fn as_json(&self) -> String {
         let mut result = self.clone();
-        if result.target_url.is_none() {
-            result.target_url = Some("http://no.url".to_string());
-        }
         if result.context.is_none() {
             result.context = Some(format!("{}-{}",
                                      env!("CARGO_PKG_NAME"),