| Message ID | 20180207212355.7464-2-aduskett@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | gobject-introspection: new series | expand |
Adam, All, On 2018-02-07 16:23 -0500, Adam Duskett spake thusly: > Match the style used with other packages such as valgrind. > > Signed-off-by: Adam Duskett <aduskett@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> However, small comment below... > --- > package/qemu/Config.in.host | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host > index 71f38ef41f..78fe54a85c 100644 > --- a/package/qemu/Config.in.host > +++ b/package/qemu/Config.in.host > @@ -1,15 +1,20 @@ > -config BR2_PACKAGE_HOST_QEMU > - bool "host qemu" > - depends on BR2_arm || BR2_armeb || BR2_aarch64 || \ > +config BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS > + bool > + default y if BR2_arm || BR2_armeb || BR2_aarch64 || \ > BR2_i386 || BR2_m68k || BR2_microblazeel || \ > BR2_microblazebe || BR2_mips || BR2_mipsel || \ > BR2_mips64 || BR2_mips64el || BR2_powerpc || \ > BR2_powerpc64 || BR2_powerpc64le || BR2_sh || \ > BR2_sparc || BR2_x86_64 This would become more readable if we were to write: default y if BR2_arm || BR2_armeb default y if BR2_aarch64 default y if BR2_i386 || BR2_x86_64 etc... But of course, not part of this patch. ;-) > +config BR2_PACKAGE_HOST_QEMU > + bool "host qemu" > + depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS > select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \ > if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE > help > - QEMU is a generic and open source machine emulator and virtualizer. > + QEMU is a generic and open source machine emulator and > + virtualizer. Spurious wrapping. Not very important... Regards, Yann E. MORIN. > This option builds an emulator for your selected architecture. > > -- > 2.14.3 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Wed, 7 Feb 2018 16:23:53 -0500, Adam Duskett wrote: > Match the style used with other packages such as valgrind. > > Signed-off-by: Adam Duskett <aduskett@gmail.com> > --- > package/qemu/Config.in.host | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) Applied to next after dropping the spurious/unrelated change in the Config.in help text, as noticed by Yann. Thanks! Thomas
diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host index 71f38ef41f..78fe54a85c 100644 --- a/package/qemu/Config.in.host +++ b/package/qemu/Config.in.host @@ -1,15 +1,20 @@ -config BR2_PACKAGE_HOST_QEMU - bool "host qemu" - depends on BR2_arm || BR2_armeb || BR2_aarch64 || \ +config BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS + bool + default y if BR2_arm || BR2_armeb || BR2_aarch64 || \ BR2_i386 || BR2_m68k || BR2_microblazeel || \ BR2_microblazebe || BR2_mips || BR2_mipsel || \ BR2_mips64 || BR2_mips64el || BR2_powerpc || \ BR2_powerpc64 || BR2_powerpc64le || BR2_sh || \ BR2_sparc || BR2_x86_64 + +config BR2_PACKAGE_HOST_QEMU + bool "host qemu" + depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \ if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE help - QEMU is a generic and open source machine emulator and virtualizer. + QEMU is a generic and open source machine emulator and + virtualizer. This option builds an emulator for your selected architecture.
Match the style used with other packages such as valgrind. Signed-off-by: Adam Duskett <aduskett@gmail.com> --- package/qemu/Config.in.host | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)