Message ID | 20180207124009.12376-1-armbru@redhat.com |
---|---|
State | New |
Headers | show |
2018-02-07 12:39 GMT+00:00 Markus Armbruster <armbru@redhat.com>: > The following changes since commit 20e0d439a6ded635ec89f6135c08cd5541c68962: > > Merge remote-tracking branch 'remotes/rth/tags/pull-hppa-20180204' into staging (2018-02-06 14:21:41 +0000) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-misc-2018-02-07 > > for you to fetch changes up to 35aeba9964fca0c698352eeebbc9410c3d299c77: > > Move include qemu/option.h from qemu-common.h to actual users (2018-02-07 13:00:03 +0100) > > ---------------------------------------------------------------- > Miscellaneous patches for 2018-02-07 > Hi. This has a compile issue on OSX: /Users/pm215/src/qemu-for-merges/block/file-posix.c:2525:28: error: implicit declaration of function 'qdict_get_str' is invalid in C99 [-Werror,-Wimplicit-function-declaration] const char *filename = qdict_get_str(options, "filename"); ^ CC block/mirror.o /Users/pm215/src/qemu-for-merges/block/file-posix.c:2525:17: error: incompatible integer to pointer conversion initializing 'const char *' with an expression of type 'int' [-Werror,-Wint-conversion] const char *filename = qdict_get_str(options, "filename"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/pm215/src/qemu-for-merges/block/file-posix.c:2565:9: error: implicit declaration of function 'qdict_put_str' is invalid in C99 [-Werror,-Wimplicit-function-declaration] qdict_put_str(options, "filename", bsd_path); ^ /Users/pm215/src/qemu-for-merges/block/file-posix.c:2565:9: note: did you mean 'qdict_get_str'? /Users/pm215/src/qemu-for-merges/block/file-posix.c:2525:28: note: 'qdict_get_str' declared here const char *filename = qdict_get_str(options, "filename"); ^ 3 errors generated. (All the other builds went OK.) thanks -- PMM