configure: Make missing docbook2man an error if man build requested

Message ID 20180207094000.11494-1-ville.skytta@iki.fi
State Accepted
Delegated to: Pablo Neira
Headers show
Series
  • configure: Make missing docbook2man an error if man build requested
Related show

Commit Message

Ville Skyttä Feb. 7, 2018, 9:40 a.m.
Previously, if man page build was enabled but no suitable docbook2man or
the like tool was found, build failed at a later stage with
undescriptive error message. Fail early and explicitly at configure
stage instead.

Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Feb. 14, 2018, 6:43 p.m. | #1
On Wed, Feb 07, 2018 at 11:40:00AM +0200, Ville Skyttä wrote:
> Previously, if man page build was enabled but no suitable docbook2man or
> the like tool was found, build failed at a later stage with
> undescriptive error message. Fail early and explicitly at configure
> stage instead.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/configure.ac b/configure.ac
index 3b8ff96..1a38653 100644
--- a/configure.ac
+++ b/configure.ac
@@ -73,7 +73,7 @@  AM_COND_IF([BUILD_MAN], [
 	      [AS_IF([test "$DOCBOOK2MAN" != "no"], [DB2MAN="$DOCBOOK2MAN"],
 		     [AS_IF([test "$DB2X_DOCBOOK2MAN" != "no"],
 			    [DB2MAN="$DB2X_DOCBOOK2MAN"],
-			    [AC_MSG_WARN([docbookx2-man/db2x_docbook2man not found, no manpages will be built])]
+			    [AC_MSG_ERROR([docbookx2-man/db2x_docbook2man not found, required for building man pages])]
 		     )]
 	     )]
 	)