From patchwork Tue Feb 6 22:27:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosen Penev X-Patchwork-Id: 870137 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bE2hmRNM"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DoNw3PQe"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zbfH21nDyz9s4q for ; Wed, 7 Feb 2018 09:27:58 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MHeJbUVAmlH4h6JcrrQNHS5Pn9nCkDjp0f7ghwb2PlY=; b=bE2hmRNMBS7G3l +3lUhOjq8qDw8UBUaeoHYLLKtypQkv8EmRxC32RVqXoPHnTPa1q3IzyCwui8xGlqaEUQZx9Av+lLl Q/trcWxU4yo/OKPQrTUncD9nDy5/ZLhYuMx+C+yxMXiI8uZoX3FAjXDWyPbsQAz10+X7A4aLkMVFs RIG20PLUfLiLWlLYtR/pkk/HICKNSUW+lYHlqd2kPzRBItsVNnrVcLTLIiPqlRRveDdHKzOzyLEPI 8w0F9R2JVq8B2hj7BU80zZwLm96mM7Z36eS47ojqXiyoHvF+U3bJvz8M6EBeL19ae+bAfFQ9VJA51 wJngUXq9y5VQ5ifIeEzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ejBiV-0005kj-8v; Tue, 06 Feb 2018 22:27:55 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ejBi7-0005Ok-6W for lede-dev@lists.infradead.org; Tue, 06 Feb 2018 22:27:35 +0000 Received: by mail-pf0-x243.google.com with SMTP id q79so1260175pfl.5 for ; Tue, 06 Feb 2018 14:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8YBlCHdboMYgEJx5v7GrFipX+MLrFw0sAtaBiRhCDS4=; b=DoNw3PQeLJZjrXW7EuJZeipKHQ/HJtj5rAc1sK5W2mHto0kV0EHUGkqNAF9cMswha1 basj8oc7mINXGpKxi1AUaIrugocUbmWZNM+wqOtxrT7twFjET0YFng9ToG+lrF3vyIwV N5bwlUEPUW8RIguoXEpPhuLIKM9cQyGKbxQeC0pgVSnnj0Sls0OJv2IUVTcipWBAz/jD Bb3n+TGBvXsDLEeiSjroxuHYyCW5J+46ZSUy5BhOXHk9hTVGeiwCWicNOmkgZpx1xPzl WJm6SieZGvzQikA+MtyPlRTEZSk3u2nLBlpRYqSQgtgW1MgSz9hn3U1+YNG2/2fgCyN8 aQyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8YBlCHdboMYgEJx5v7GrFipX+MLrFw0sAtaBiRhCDS4=; b=ZbpHwqpRNoc8luSsIERbeecR0j3tzOvvM4nMT1hl8tbu3OlRWj/TFyDCTKWZ8A5J0B 0lok2rEXgt08ebNCkM3j/GPuBYiK0OcE/wqqSD4bpgrA2FwkiA7NXf0bh8t/jkhBj8Y0 ZbmHd/zoNknzQzyeW90jKRzoufDT0HKTdJRHBlxAI84jmn0YSx2vXny16Nm5HdyK4XJy LkUSgf1/3opDTAJSBsuBj+xRvwxbOQlVBmcCIObmtNyXV76ATjz1VEDvv6SURDD3JyjM yLKfYAOP0wpXNuEncs/g+ddjWrjkJvk/n4gbRg4uEuw/HSdhkmNy7PQ/0riJ5YBqGwWp 1Jrg== X-Gm-Message-State: APf1xPBzmA3R2KSyXck0K9rwYjU5YRWuXE9s9Bv8cJMn/SZ90nX8urCk Mw5bBM041KiVYmSpfd1gmH3QN6wg X-Google-Smtp-Source: AH8x226bUaX1+wL1ZIyLMHyc4Im25Os9v/M5It4B4kTWoYmmkjVGft+1H+kWyPA+k6t0m/7ZHzoCIA== X-Received: by 10.98.93.9 with SMTP id r9mr3821044pfb.55.1517956040153; Tue, 06 Feb 2018 14:27:20 -0800 (PST) Received: from DESKTOP-CEH0M93.lan ([2001:470:1f05:c3e:8de7:e3d0:36b6:19fe]) by smtp.gmail.com with ESMTPSA id e26sm60492pfi.76.2018.02.06.14.27.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Feb 2018 14:27:19 -0800 (PST) From: Rosen Penev To: lede-dev@lists.infradead.org Date: Tue, 6 Feb 2018 14:27:29 -0800 Message-Id: <1517956050-32412-2-git-send-email-rosenp@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517956050-32412-1-git-send-email-rosenp@gmail.com> References: <1517956050-32412-1-git-send-email-rosenp@gmail.com> X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:400e:c00:0:0:0:243 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH 2/3] ag71xx: Remove ___cacheline_aligned from ring structs. X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rosen Penev MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Qualcomm's struct members and inner workings of their driver are all different. While this might make sense for their driver, it seems to hurt here. In iperf3, i've seen inconsistent results including a drop of 100mbps on an Archer C7v4. This patch keeps the results high and relatively consistent. Signed-off-by: Rosen Penev --- .../linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h index d7897a9..8d7976e 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx.h @@ -159,8 +159,8 @@ struct ag71xx { * Critical data related to the per-packet data path are clustered * early in this structure to help improve the D-cache footprint. */ - struct ag71xx_ring rx_ring ____cacheline_aligned; - struct ag71xx_ring tx_ring ____cacheline_aligned; + struct ag71xx_ring rx_ring; + struct ag71xx_ring tx_ring; unsigned int max_frame_len; unsigned int desc_pktlen_mask;