| Message ID | 20180206174035.1683-1-aduskett@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] ncurses-next: fix build failure with 6.1 | expand |
Hello, The commit title shouldn't contain "next". If you want to tag a patch for next, use: git format-patch --subject-prefix="PATCH next" Indeed we don't want "next" in the commit title to be present forever in the Git history. On Tue, 6 Feb 2018 12:40:35 -0500, Adam Duskett wrote: > Ncurses 6.1 introduces the config option --disable-stripping which is set > to no by default. > > Set this option to ensure that ncurses doesn't try to strip the executables. > > Fixes: > http://autobuild.buildroot.net/results/3a5/3a5ddfcf7cd3a5c2bc068e3e33c823d6bcd3e79b An empty line here is good to have, to separate the commit log from the SoB line. > Signed-off-by: Adam Duskett <aduskett@gmail.com> > --- > package/ncurses/ncurses.mk | 1 + > 1 file changed, 1 insertion(+) Applied to next with those minor nits fixed.
diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk index eccfbecb8b..90cf4a4dc5 100644 --- a/package/ncurses/ncurses.mk +++ b/package/ncurses/ncurses.mk @@ -25,6 +25,7 @@ NCURSES_CONF_OPTS = \ --enable-const \ --enable-overwrite \ --enable-pc-files \ + --disable-stripping \ --with-pkg-config-libdir="/usr/lib/pkgconfig" \ $(if $(BR2_PACKAGE_NCURSES_TARGET_PROGS),,--without-progs) \ --without-manpages
Ncurses 6.1 introduces the config option --disable-stripping which is set to no by default. Set this option to ensure that ncurses doesn't try to strip the executables. Fixes: http://autobuild.buildroot.net/results/3a5/3a5ddfcf7cd3a5c2bc068e3e33c823d6bcd3e79b Signed-off-by: Adam Duskett <aduskett@gmail.com> --- package/ncurses/ncurses.mk | 1 + 1 file changed, 1 insertion(+)