| Message ID | 1517930128-26181-5-git-send-email-jagan@amarulasolutions.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | arm: sunxi: Use proper and meaningful Kconfig entries | expand |
Hi, On Tue, Feb 06, 2018 at 08:45:21PM +0530, Jagan Teki wrote: > Add simple and meaningful kconfig option for rsb.c > instead of using MACH type on Makefile. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/arm/mach-sunxi/Kconfig | 10 ++++++++++ > arch/arm/mach-sunxi/Makefile | 3 +-- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index cf999ab..7ab1990 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -23,6 +23,14 @@ config MFD_SUN6I_PRCM > Support for the PRCM (Power/Reset/Clock Management) unit available > in A31 SoC. > > +config SUNXI_RSB Following the rest of the convention we have, that would be SUN8I_RSB. Maxime
On Tue, Feb 6, 2018 at 9:19 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > Hi, > > On Tue, Feb 06, 2018 at 08:45:21PM +0530, Jagan Teki wrote: >> Add simple and meaningful kconfig option for rsb.c >> instead of using MACH type on Makefile. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> arch/arm/mach-sunxi/Kconfig | 10 ++++++++++ >> arch/arm/mach-sunxi/Makefile | 3 +-- >> 2 files changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig >> index cf999ab..7ab1990 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -23,6 +23,14 @@ config MFD_SUN6I_PRCM >> Support for the PRCM (Power/Reset/Clock Management) unit available >> in A31 SoC. >> >> +config SUNXI_RSB > > Following the rest of the convention we have, that would be SUN8I_RSB. Followed Linux notation to sync with, where the driver will also have support AC100.
On Fri, Feb 09, 2018 at 04:09:41PM +0530, Jagan Teki wrote: > On Tue, Feb 6, 2018 at 9:19 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > Hi, > > > > On Tue, Feb 06, 2018 at 08:45:21PM +0530, Jagan Teki wrote: > >> Add simple and meaningful kconfig option for rsb.c > >> instead of using MACH type on Makefile. > >> > >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > >> --- > >> arch/arm/mach-sunxi/Kconfig | 10 ++++++++++ > >> arch/arm/mach-sunxi/Makefile | 3 +-- > >> 2 files changed, 11 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > >> index cf999ab..7ab1990 100644 > >> --- a/arch/arm/mach-sunxi/Kconfig > >> +++ b/arch/arm/mach-sunxi/Kconfig > >> @@ -23,6 +23,14 @@ config MFD_SUN6I_PRCM > >> Support for the PRCM (Power/Reset/Clock Management) unit available > >> in A31 SoC. > >> > >> +config SUNXI_RSB > > > > Following the rest of the convention we have, that would be SUN8I_RSB. > > Followed Linux notation to sync with, where the driver will also have > support AC100. AC100 is a device connected on that bus, not the bus itself. Maxime
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index cf999ab..7ab1990 100644 --- a/arch/arm/mach-sunxi/Kconfig +++ b/arch/arm/mach-sunxi/Kconfig @@ -23,6 +23,14 @@ config MFD_SUN6I_PRCM Support for the PRCM (Power/Reset/Clock Management) unit available in A31 SoC. +config SUNXI_RSB + bool "Allwinner sunXi Reduced Serial Bus Driver" + help + Say y here to enable support for Allwinner's Reduced Serial Bus + (RSB) support. This controller is responsible for communicating + with various RSB based devices, such as AXP223, AXP8XX PMICs, + and AC100/AC200 ICs. + config SUNXI_HIGH_SRAM bool default n @@ -185,6 +193,7 @@ config MACH_SUN9I select MFD_SUN6I_PRCM select SUNXI_HIGH_SRAM select SUNXI_GEN_SUN6I + select SUNXI_RSB select SUPPORT_SPL config MACH_SUN50I @@ -213,6 +222,7 @@ endchoice # The sun8i SoCs share a lot, this helps to avoid a lot of "if A23 || A33" config MACH_SUN8I bool + select SUNXI_RSB select MFD_SUN6I_PRCM default y if MACH_SUN8I_A23 default y if MACH_SUN8I_A33 diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile index a6721ad..8f30979 100644 --- a/arch/arm/mach-sunxi/Makefile +++ b/arch/arm/mach-sunxi/Makefile @@ -18,8 +18,7 @@ obj-y += usb_phy.o endif obj-$(CONFIG_I2C_SUN6I_P2WI) += p2wi.o obj-$(CONFIG_MFD_SUN6I_PRCM) += prcm.o -obj-$(CONFIG_MACH_SUN8I) += rsb.o -obj-$(CONFIG_MACH_SUN9I) += rsb.o +obj-$(CONFIG_SUNXI_RSB) += rsb.o obj-$(CONFIG_MACH_SUN4I) += clock_sun4i.o obj-$(CONFIG_MACH_SUN5I) += clock_sun4i.o obj-$(CONFIG_MACH_SUN6I) += clock_sun6i.o
Add simple and meaningful kconfig option for rsb.c instead of using MACH type on Makefile. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm/mach-sunxi/Kconfig | 10 ++++++++++ arch/arm/mach-sunxi/Makefile | 3 +-- 2 files changed, 11 insertions(+), 2 deletions(-)