[v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb

Message ID 20180206110810.9093-1-brgl@bgdev.pl
State New
Headers show
Series
  • [v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
Related show

Commit Message

Bartosz Golaszewski Feb. 6, 2018, 11:08 a.m.
Using compatible strings without the <manufacturer> part for at24 is
deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
document the compatible property"). Use a correct 'atmel,<model>'
value.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
- explicitly mention the commit in which we deprecated compatible
  fallbacks other than "atmel,<manufacturer>"

 arch/arc/boot/dts/axs10x_mb.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alexey Brodkin Feb. 6, 2018, 12:25 p.m. | #1
Hi Bartosz,

On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
> Using compatible strings without the <manufacturer> part for at24 is
> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
> document the compatible property"). Use a correct 'atmel,<model>'
> value.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

So my further input might be a bit unexpected :)

I took a look at the real board and understood that we specified in .dts
wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
external device) and instead I2C EEPROM we really have connected (but not yet
obviously used in the Linux kernel) is NXP's PCF8594C-2.

That said we may accept your change because it doesn't break anything
and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
Or we may drop your change at all since I'm going to replace corresponding nodes.

-Alexey
Bartosz Golaszewski Feb. 6, 2018, 6:01 p.m. | #2
2018-02-06 13:25 GMT+01:00 Alexey Brodkin <Alexey.Brodkin@synopsys.com>:
> Hi Bartosz,
>
> On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
>> Using compatible strings without the <manufacturer> part for at24 is
>> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
>> document the compatible property"). Use a correct 'atmel,<model>'
>> value.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
>
> So my further input might be a bit unexpected :)
>
> I took a look at the real board and understood that we specified in .dts
> wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
> external device) and instead I2C EEPROM we really have connected (but not yet
> obviously used in the Linux kernel) is NXP's PCF8594C-2.
>
> That said we may accept your change because it doesn't break anything
> and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
> Or we may drop your change at all since I'm going to replace corresponding nodes.
>
> -Alexey

Looks like PCF8594C-2 is compatible with atmel,24c04 - when you'll be
submitting this patch, please extend the at24 DT bindings with a new
naming exception (just like the one for renesas).

Feel free to drop this patch if you plan to submit the fix soon -
otherwise, apply it if it may take some time.

Thanks,
Bartosz
Alexey Brodkin Feb. 6, 2018, 9:04 p.m. | #3
Hi Bartosz,

> -----Original Message-----
> From: Bartosz Golaszewski [mailto:brgl@bgdev.pl]
> Sent: Tuesday, February 6, 2018 7:02 PM
> To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: linux-kernel@vger.kernel.org; mark.rutland@arm.com; Vineet.Gupta1@synopsys.com; robh+dt@kernel.org;
> devicetree@vger.kernel.org; linux-snps-arc@lists.infradead.org
> Subject: Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb
> 
> 2018-02-06 13:25 GMT+01:00 Alexey Brodkin <Alexey.Brodkin@synopsys.com>:
> > Hi Bartosz,
> >
> > On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote:
> >> Using compatible strings without the <manufacturer> part for at24 is
> >> deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently
> >> document the compatible property"). Use a correct 'atmel,<model>'
> >> value.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >
> > So my further input might be a bit unexpected :)
> >
> > I took a look at the real board and understood that we specified in .dts
> > wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some
> > external device) and instead I2C EEPROM we really have connected (but not yet
> > obviously used in the Linux kernel) is NXP's PCF8594C-2.
> >
> > That said we may accept your change because it doesn't break anything
> > and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes.
> > Or we may drop your change at all since I'm going to replace corresponding nodes.
> >
> > -Alexey
> 
> Looks like PCF8594C-2 is compatible with atmel,24c04 - when you'll be
> submitting this patch, please extend the at24 DT bindings with a new
> naming exception (just like the one for renesas).

Thanks for checking this.

> Feel free to drop this patch if you plan to submit the fix soon -
> otherwise, apply it if it may take some time.

No I think it worth applying especially in the light of your comment about NXP EEPROM.

Vineet, could you please take this one?

-Alexey
Vineet Gupta Feb. 6, 2018, 10:39 p.m. | #4
On 02/06/2018 01:04 PM, Alexey Brodkin wrote:
>> Feel free to drop this patch if you plan to submit the fix soon -
>> otherwise, apply it if it may take some time.
> No I think it worth applying especially in the light of your comment about NXP EEPROM.
>
> Vineet, could you please take this one?

I've added your Acked-by to patch and pushed to for-curr !

-Vineet

Patch

diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
index 74d070cd3c13..47b74fbc403c 100644
--- a/arch/arc/boot/dts/axs10x_mb.dtsi
+++ b/arch/arc/boot/dts/axs10x_mb.dtsi
@@ -214,13 +214,13 @@ 
 			};
 
 			eeprom@0x54{
-				compatible = "24c01";
+				compatible = "atmel,24c01";
 				reg = <0x54>;
 				pagesize = <0x8>;
 			};
 
 			eeprom@0x57{
-				compatible = "24c04";
+				compatible = "atmel,24c04";
 				reg = <0x57>;
 				pagesize = <0x8>;
 			};