From patchwork Tue Mar 15 09:00:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 86901 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4CF3AB6FF3 for ; Tue, 15 Mar 2011 20:04:24 +1100 (EST) Received: from localhost ([127.0.0.1]:45498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzQAv-0005Zc-Dq for incoming@patchwork.ozlabs.org; Tue, 15 Mar 2011 05:04:21 -0400 Received: from [140.186.70.92] (port=50647 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzQ7T-0003RX-5k for qemu-devel@nongnu.org; Tue, 15 Mar 2011 05:00:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzQ7S-0008WE-4G for qemu-devel@nongnu.org; Tue, 15 Mar 2011 05:00:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzQ7R-0008Vx-OW for qemu-devel@nongnu.org; Tue, 15 Mar 2011 05:00:46 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2F90fOU019377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 15 Mar 2011 05:00:43 -0400 Received: from localhost (dhcp193-58.pnq.redhat.com [10.65.193.58]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2F90bww010912; Tue, 15 Mar 2011 05:00:40 -0400 From: Amit Shah To: qemu list Date: Tue, 15 Mar 2011 14:30:28 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Amit Shah , Markus Armbruster , Gerd Hoffmann Subject: [Qemu-devel] [PATCH 1/2] virtio-console: Keep chardev open for other users after hot-unplug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After a hot-unplug operation, the previous behaviour was to close the chardev. That meant the chardev couldn't be re-used. Also, since chardev hot-plug isn't possible so far, this means virtio-console hot-plug isn't feasible as well. With this change, the chardev is kept around. A new virtio-console channel can then be hot-plugged with the same chardev and things will continue to work. Signed-off-by: Amit Shah --- hw/virtio-console.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index c235b27..84ed572 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -82,7 +82,11 @@ static int virtconsole_exitfn(VirtIOSerialPort *port) if (vcon->chr) { port->info->have_data = NULL; - qemu_chr_close(vcon->chr); + /* + * Instead of closing the chardev, free it so it can be used + * for other purposes. + */ + qemu_chr_add_handlers(vcon->chr, NULL, NULL, NULL, NULL); } return 0;