From patchwork Sat Feb 3 23:21:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 868966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zYqcM3jvTz9t3x for ; Sun, 4 Feb 2018 10:21:38 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 07F4926665; Sat, 3 Feb 2018 23:21:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0lrL3sYI+ker; Sat, 3 Feb 2018 23:21:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id E24A82635F; Sat, 3 Feb 2018 23:21:35 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 1CCB11C041E for ; Sat, 3 Feb 2018 23:21:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 17AC9262E0 for ; Sat, 3 Feb 2018 23:21:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gbl+fzuQ90Uf for ; Sat, 3 Feb 2018 23:21:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by silver.osuosl.org (Postfix) with ESMTPS id 0B12C262D2 for ; Sat, 3 Feb 2018 23:21:31 +0000 (UTC) Received: from localhost.localdomain ([188.110.57.104]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lg5kl-1f6ENv0uaZ-00pZMd for ; Sun, 04 Feb 2018 00:21:28 +0100 From: Peter Seiderer To: buildroot@buildroot.org Date: Sun, 4 Feb 2018 00:21:27 +0100 Message-Id: <20180203232127.22765-1-ps.report@gmx.net> X-Mailer: git-send-email 2.16.1 X-Provags-ID: V03:K0:GL8DDynmwsAHsR1HHTw04VXiRH0Uwu/ZsXHatHONK7aIyRduAOy OiOpkjF+nm3wbyRcpB336j6ij/CsufLzCZCxH4j3e/+9r2/g1UDgTT6bcN9TPUmCG9OuM1L 2i8FILDjo5LAxKFQB6MmFajSNKW/DFNDtD18PkIB8jlEleVsc1YhjfHXHoSYqAlESbB8M2m 2TzdhlZM32pwwS6GMGeCw== X-UI-Out-Filterresults: notjunk:1; V01:K0:mEuwt5GSSEI=:fMaoq09nWhq4IQda4yHHdB kMU1/RsQeKLXJe8Pzqfifk4RhikTh44fMuol8PhDnCn8HdztYqjDt9X8eneVY5gg/v300GcAL Nj7hDgGfkL+uwm8hevmXCI9YKNC22e87Rr9TEGcilyS1nysRnM3w0+S8DSxBSJQFirBjsESAz ru/qLa8wHeHRqVHa6mb4z7RTOFaZaJhT11Q+Xh/6c9neBarWesXSvC6vyPB/ZXSe6EyE3VZ73 lDry8yc51Bn1avTbmSFiIEFQ4oDbmmHvnhK1RzEUDTqL2d9L6YQ3uXoK6jUQakxinrtRvH4zE nvgKNG3re20k/SxSJM573x6RD670y0tJFBYFF6msNgP35sMIaQ8Ekg4Z1Yc6DW36UoBoumY76 oya6TqgT+FErLu3KtEJ6OH4GSRzMmF4kkF/uOE/ZuncKj/WVLMCVZj0OgqiIl3EwV79r4NfuD V4vcmauqu0zchNm+JaPBxUbyBIS2n/6Ol/8QIsoohbjQEH3UcV7Wmrz1zBsDNswJcwcJWWux2 EolQt2QUMEjhuDXUN+/i0fhk4UHKw9EEF1FMtO6BZwKBRqnEaKq1HmJdwA7RGWZjL11qS59L2 LCbqkSX9l3Cs6F/vZsOUedxBTloU6CBczCjh4aXatWIrmGLNRTdL2W1fHQYHR8aR/7oXza1iK /Ke3cgjCcU7t6rBrmlg4XwuVBrqqi64QIVHahoI7vobl/ZuGFhUcrjkjZ5QFTYBAZhVxNisft OqNzR7pbNmC4hPq3fPmbMGMRoFQzznJEfld+abGl9bapdwdM5/5BrviQg0wKolHNmhDGJmWxB V9MgmkW+1Xc7cCmSL1z79TV+Lwf1g== Subject: [Buildroot] [RFC v1] libv4l: fix qv4l2 libatomic related compile failure X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes [1]: sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' [1] http://autobuild.buildroot.net/results/baa2595e1acdf4e795fbb940ca57fd136c827da3 Signed-off-by: Peter Seiderer --- Patch fixes the qv4l2 linking problem for sparc, but adds a libatomic dependency to all v4l libraries. Any better suggestions to add libatomic linking only to utils/qv4l2? --- .../0003-configure.ac-check-for-libatomic.patch | 30 ++++++++++++++++++++++ package/libv4l/libv4l.mk | 5 ++++ 2 files changed, 35 insertions(+) create mode 100644 package/libv4l/0003-configure.ac-check-for-libatomic.patch diff --git a/package/libv4l/0003-configure.ac-check-for-libatomic.patch b/package/libv4l/0003-configure.ac-check-for-libatomic.patch new file mode 100644 index 0000000000..78aaada653 --- /dev/null +++ b/package/libv4l/0003-configure.ac-check-for-libatomic.patch @@ -0,0 +1,30 @@ +From 87978992fbcba13550e900fbe9abb2a60be98bf4 Mon Sep 17 00:00:00 2001 +From: Peter Seiderer +Date: Sun, 4 Feb 2018 00:08:45 +0100 +Subject: [PATCH] configure.ac: check for libatomic + +Fixes: + + .../sparc-buildroot-linux-uclibc/bin/ld: qv4l2-qv4l2.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0' + +Signed-off-by: Peter Seiderer +--- + configure.ac | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/configure.ac b/configure.ac +index dc1e9cbf..65a3caaa 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -279,6 +279,8 @@ AS_IF([test x$enable_shared != xno], + [have_pthread=no])], + [have_pthread=no]) + ++AC_SEARCH_LIBS([__atomic_load_4], [atomic]) ++ + # The dlopen() function is in the C library for *BSD and in + # libdl on GLIBC-based systems + +-- +2.16.1 + diff --git a/package/libv4l/libv4l.mk b/package/libv4l/libv4l.mk index 11061306c7..bc9b5c9abd 100644 --- a/package/libv4l/libv4l.mk +++ b/package/libv4l/libv4l.mk @@ -11,6 +11,11 @@ LIBV4L_INSTALL_STAGING = YES LIBV4L_DEPENDENCIES = host-pkgconf LIBV4L_CONF_OPTS = --disable-doxygen-doc +# patch 0003-configure.ac-check-for-libatomic.patch touches configure.ac +LIBV4L_AUTORECONF = YES +# host-gettext needed for autoreconf to work +LIBV4L_DEPENDENCIES += host-gettext + # fix uclibc-ng configure/compile LIBV4L_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'