[2/2] i2c-bfin-twi: Improve a size determination in i2c_bfin_twi_probe()

Message ID 3a856fe7-5217-adcb-1da9-192a578b0422@users.sourceforge.net
State Not Applicable
Headers show
  • I2C-Blackfin TWI: Adjustments for i2c_bfin_twi_probe()
Related show

Commit Message

SF Markus Elfring Feb. 2, 2018, 6:13 p.m.
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 2 Feb 2018 19:01:14 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
 drivers/i2c/busses/i2c-bfin-twi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index ed596fd56b8b..f57e3247f717 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -619,8 +619,7 @@  static int i2c_bfin_twi_probe(struct platform_device *pdev)
 	int rc;
 	unsigned int clkhilow;
-	iface = devm_kzalloc(&pdev->dev, sizeof(struct bfin_twi_iface),
+	iface = devm_kzalloc(&pdev->dev, sizeof(*iface), GFP_KERNEL);
 	if (!iface)
 		return -ENOMEM;