[v5,1/2] libkrb5: New package

Message ID 1517593141-26017-1-git-send-email-nerv@dawncrow.de
State Superseded
Headers show
Series
  • [v5,1/2] libkrb5: New package
Related show

Commit Message

André Hentschel Feb. 2, 2018, 5:39 p.m.
Signed-off-by: André Hentschel <nerv@dawncrow.de>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libkrb5/Config.in    | 15 +++++++++++++++
 package/libkrb5/libkrb5.hash |  2 ++
 package/libkrb5/libkrb5.mk   | 27 +++++++++++++++++++++++++++
 5 files changed, 46 insertions(+)
 create mode 100644 package/libkrb5/Config.in
 create mode 100644 package/libkrb5/libkrb5.hash
 create mode 100644 package/libkrb5/libkrb5.mk

Comments

Sam Voss Feb. 6, 2018, 1:07 p.m. | #1
André,

On Fri, Feb 2, 2018 at 6:39 PM, André Hentschel <nerv@dawncrow.de> wrote:
> Signed-off-by: André Hentschel <nerv@dawncrow.de>
> ---
>  DEVELOPERS                   |  1 +
>  package/Config.in            |  1 +
>  package/libkrb5/Config.in    | 15 +++++++++++++++
>  package/libkrb5/libkrb5.hash |  2 ++
>  package/libkrb5/libkrb5.mk   | 27 +++++++++++++++++++++++++++
>  5 files changed, 46 insertions(+)
>  create mode 100644 package/libkrb5/Config.in
>  create mode 100644 package/libkrb5/libkrb5.hash
>  create mode 100644 package/libkrb5/libkrb5.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9048d45..a8fa9ae 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -111,6 +111,7 @@ F:  package/ktap/
>
>  N:     André Hentschel <nerv@dawncrow.de>
>  F:     package/azure-iot-sdk-c/
> +F:     package/libkrb5/
>  F:     package/openal/
>  F:     package/p7zip/
>  F:     package/wine/
> diff --git a/package/Config.in b/package/Config.in
> index 9a6b199..86042f4 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1374,6 +1374,7 @@ menu "Networking"
>         source "package/libhttpparser/Config.in"
>         source "package/libidn/Config.in"
>         source "package/libiscsi/Config.in"
> +       source "package/libkrb5/Config.in"
>         source "package/libldns/Config.in"
>         source "package/libmaxminddb/Config.in"
>         source "package/libmbus/Config.in"
> diff --git a/package/libkrb5/Config.in b/package/libkrb5/Config.in
> new file mode 100644
> index 0000000..bdddd2e
> --- /dev/null
> +++ b/package/libkrb5/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LIBKRB5
> +       bool "libkrb5"
> +       # needs fork()
> +       depends on BR2_USE_MMU
> +       # static libs are not supported on all platforms
> +       depends on !(BR2_STATIC_LIBS && (BR2_ARM_CPU_ARMV7M || BR2_m68k))
> +       help
> +         Kerberos is a system for authenticating users and services
> +         on a network. Kerberos is a trusted third-party service.
> +         That means that there is a third party (the Kerberos server)
> +         that is trusted by all the entities on the network
> +         (users and services, usually called "principals").
> +         This is the MIT reference implementation of Kerberos V5.
> +
> +         https://web.mit.edu/kerberos/
> diff --git a/package/libkrb5/libkrb5.hash b/package/libkrb5/libkrb5.hash
> new file mode 100644
> index 0000000..59552d7
> --- /dev/null
> +++ b/package/libkrb5/libkrb5.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated after checking pgp signature
> +sha256 faeb125f83b0fb4cdb2f99f088140631bb47d975982de0956d18c85842969e08        krb5-1.16.tar.gz
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> new file mode 100644
> index 0000000..3cb64d6
> --- /dev/null
> +++ b/package/libkrb5/libkrb5.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# libkrb5
> +#
> +################################################################################
> +
> +LIBKRB5_VERSION = 1.16
> +LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.16

Can the version number be taken out of the url, and instead use
$(LIBKRB5_VERSION) once again here?

> +LIBKRB5_SOURCE = krb5-$(LIBKRB5_VERSION).tar.gz
> +LIBKRB5_SUBDIR = src
> +LIBKRB5_LICENSE = MIT
> +LIBKRB5_LICENSE_FILES = NOTICE
> +LIBKRB5_INSTALL_STAGING = YES
> +
> +# The configure script uses AC_TRY_RUN tests to check for those values,
> +# which doesn't work in a cross-compilation scenario. Therefore,
> +# we feed the configure script with the correct answer for those tests
> +LIBKRB5_CONF_ENV = \
> +       ac_cv_printf_positional=yes \
> +       ac_cv_func_regcomp=yes \
> +       krb5_cv_attr_constructor_destructor=yes,yes
> +
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +LIBKRB5_CONF_OPTS += --disable-thread-support
> +endif
> +
> +$(eval $(autotools-package))
> --
> 2.7.4

Thanks!

Sam
Sam Voss Feb. 6, 2018, 1:28 p.m. | #2
André,

On Tue, Feb 6, 2018 at 2:07 PM, Sam Voss <sam.voss@rockwellcollins.com> wrote:
> André,
>
[snip]
>> +LIBKRB5_VERSION = 1.16
>> +LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.16
>
> Can the version number be taken out of the url, and instead use
> $(LIBKRB5_VERSION) once again here?

I actually take this back. I went and checked and minor revisions are
also stored in this folder, so that will not work.

Thanks,

Sam
Arnout Vandecappelle Feb. 6, 2018, 1:42 p.m. | #3
On 06-02-18 14:28, Sam Voss wrote:
> André,
> 
> On Tue, Feb 6, 2018 at 2:07 PM, Sam Voss <sam.voss@rockwellcollins.com> wrote:
>> André,
>>
> [snip]
>>> +LIBKRB5_VERSION = 1.16
>>> +LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.16
>>
>> Can the version number be taken out of the url, and instead use
>> $(LIBKRB5_VERSION) once again here?
> 
> I actually take this back. I went and checked and minor revisions are
> also stored in this folder, so that will not work.

 In such a case we usually have a _VERSION_MAJOR variable that is used in the
definition of _VERSION and _SITE.

 Regards,
 Arnout
André Hentschel Feb. 6, 2018, 5:22 p.m. | #4
Am 06.02.2018 um 14:42 schrieb Arnout Vandecappelle:
> 
> 
> On 06-02-18 14:28, Sam Voss wrote:
>> André,
>>
>> On Tue, Feb 6, 2018 at 2:07 PM, Sam Voss <sam.voss@rockwellcollins.com> wrote:
>>> André,
>>>
>> [snip]
>>>> +LIBKRB5_VERSION = 1.16
>>>> +LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.16
>>>
>>> Can the version number be taken out of the url, and instead use
>>> $(LIBKRB5_VERSION) once again here?
>>
>> I actually take this back. I went and checked and minor revisions are
>> also stored in this folder, so that will not work.
> 
>  In such a case we usually have a _VERSION_MAJOR variable that is used in the
> definition of _VERSION and _SITE.
> 
>  Regards,
>  Arnout
> 
thanks for the hint, I'll send try 6

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 9048d45..a8fa9ae 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -111,6 +111,7 @@  F:	package/ktap/
 
 N:	André Hentschel <nerv@dawncrow.de>
 F:	package/azure-iot-sdk-c/
+F:	package/libkrb5/
 F:	package/openal/
 F:	package/p7zip/
 F:	package/wine/
diff --git a/package/Config.in b/package/Config.in
index 9a6b199..86042f4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1374,6 +1374,7 @@  menu "Networking"
 	source "package/libhttpparser/Config.in"
 	source "package/libidn/Config.in"
 	source "package/libiscsi/Config.in"
+	source "package/libkrb5/Config.in"
 	source "package/libldns/Config.in"
 	source "package/libmaxminddb/Config.in"
 	source "package/libmbus/Config.in"
diff --git a/package/libkrb5/Config.in b/package/libkrb5/Config.in
new file mode 100644
index 0000000..bdddd2e
--- /dev/null
+++ b/package/libkrb5/Config.in
@@ -0,0 +1,15 @@ 
+config BR2_PACKAGE_LIBKRB5
+	bool "libkrb5"
+	# needs fork()
+	depends on BR2_USE_MMU
+	# static libs are not supported on all platforms
+	depends on !(BR2_STATIC_LIBS && (BR2_ARM_CPU_ARMV7M || BR2_m68k))
+	help
+	  Kerberos is a system for authenticating users and services
+	  on a network. Kerberos is a trusted third-party service.
+	  That means that there is a third party (the Kerberos server)
+	  that is trusted by all the entities on the network
+	  (users and services, usually called "principals").
+	  This is the MIT reference implementation of Kerberos V5.
+
+	  https://web.mit.edu/kerberos/
diff --git a/package/libkrb5/libkrb5.hash b/package/libkrb5/libkrb5.hash
new file mode 100644
index 0000000..59552d7
--- /dev/null
+++ b/package/libkrb5/libkrb5.hash
@@ -0,0 +1,2 @@ 
+# Locally calculated after checking pgp signature
+sha256	faeb125f83b0fb4cdb2f99f088140631bb47d975982de0956d18c85842969e08	krb5-1.16.tar.gz
diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
new file mode 100644
index 0000000..3cb64d6
--- /dev/null
+++ b/package/libkrb5/libkrb5.mk
@@ -0,0 +1,27 @@ 
+################################################################################
+#
+# libkrb5
+#
+################################################################################
+
+LIBKRB5_VERSION = 1.16
+LIBKRB5_SITE = https://web.mit.edu/kerberos/dist/krb5/1.16
+LIBKRB5_SOURCE = krb5-$(LIBKRB5_VERSION).tar.gz
+LIBKRB5_SUBDIR = src
+LIBKRB5_LICENSE = MIT
+LIBKRB5_LICENSE_FILES = NOTICE
+LIBKRB5_INSTALL_STAGING = YES
+
+# The configure script uses AC_TRY_RUN tests to check for those values,
+# which doesn't work in a cross-compilation scenario. Therefore,
+# we feed the configure script with the correct answer for those tests
+LIBKRB5_CONF_ENV = \
+	ac_cv_printf_positional=yes \
+	ac_cv_func_regcomp=yes \
+	krb5_cv_attr_constructor_destructor=yes,yes
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBKRB5_CONF_OPTS += --disable-thread-support
+endif
+
+$(eval $(autotools-package))