| Message ID | 20180202130336.24719-3-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Modularize generated QAPI code | expand |
On 02/02/2018 07:03 AM, Markus Armbruster wrote: > Each generator carries a copyright notice for the generator itself, > and another one for the files it generates. Only the former have been > updated along the way, the latter have not, and are all out of date. > > Fix by copying the generator's copyright notice to the generated files > instead. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > +++ b/scripts/qapi-commands.py > @@ -1,16 +1,17 @@ > -# > -# QAPI command marshaller generator > -# > -# Copyright IBM, Corp. 2011 > -# Copyright (C) 2014-2016 Red Hat, Inc. > -# > -# Authors: > -# Anthony Liguori <aliguori@us.ibm.com> > -# Michael Roth <mdroth@linux.vnet.ibm.com> > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > -# See the COPYING file in the top-level directory. > +""" > +QAPI command marshaller generator > + > +Copyright IBM, Corp. 2011 > +Copyright (C) 2014-2018 Red Hat, Inc. > + > +Authors: > + Anthony Liguori <aliguori@us.ibm.com> > + Michael Roth <mdroth@linux.vnet.ibm.com> > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > +See the COPYING file in the top-level directory. > +""" So python lets you start a file with a string constant that is not associated with any variable name? > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qmp-marshal.c', 'qmp-commands.h', > - blurb) > + blurb, __doc__) Ah, and there's what I was missing - python auto-assigns such an initial string to a magic automatic variable. Cool language feature I hadn't seen before! Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> writes: > On 02/02/2018 07:03 AM, Markus Armbruster wrote: >> Each generator carries a copyright notice for the generator itself, >> and another one for the files it generates. Only the former have been >> updated along the way, the latter have not, and are all out of date. >> >> Fix by copying the generator's copyright notice to the generated files >> instead. >> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> --- > >> +++ b/scripts/qapi-commands.py >> @@ -1,16 +1,17 @@ >> -# >> -# QAPI command marshaller generator >> -# >> -# Copyright IBM, Corp. 2011 >> -# Copyright (C) 2014-2016 Red Hat, Inc. >> -# >> -# Authors: >> -# Anthony Liguori <aliguori@us.ibm.com> >> -# Michael Roth <mdroth@linux.vnet.ibm.com> >> -# Markus Armbruster <armbru@redhat.com> >> -# >> -# This work is licensed under the terms of the GNU GPL, version 2. >> -# See the COPYING file in the top-level directory. >> +""" >> +QAPI command marshaller generator >> + >> +Copyright IBM, Corp. 2011 >> +Copyright (C) 2014-2018 Red Hat, Inc. >> + >> +Authors: >> + Anthony Liguori <aliguori@us.ibm.com> >> + Michael Roth <mdroth@linux.vnet.ibm.com> >> + Markus Armbruster <armbru@redhat.com> >> + >> +This work is licensed under the terms of the GNU GPL, version 2. >> +See the COPYING file in the top-level directory. >> +""" > > So python lets you start a file with a string constant that is not > associated with any variable name? It's the module's doc string, done the same way as function doc strings. https://www.python.org/dev/peps/pep-0257/#what-is-a-docstring >> (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, >> 'qmp-marshal.c', 'qmp-commands.h', >> - blurb) >> + blurb, __doc__) > > Ah, and there's what I was missing - python auto-assigns such an initial > string to a magic automatic variable. Cool language feature I hadn't > seen before! > > Reviewed-by: Eric Blake <eblake@redhat.com> Thanks!
Hi On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <armbru@redhat.com> wrote: > Each generator carries a copyright notice for the generator itself, > and another one for the files it generates. Only the former have been > updated along the way, the latter have not, and are all out of date. > > Fix by copying the generator's copyright notice to the generated files > instead. That makes sense, but we loose the Author lines in the generated files. Not a big deal I guess, but worth to point out, no? > > Signed-off-by: Markus Armbruster <armbru@redhat.com> Other than that, Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > scripts/qapi-commands.py | 34 +++++++++++++++------------------- > scripts/qapi-event.py | 32 ++++++++++++++------------------ > scripts/qapi-introspect.py | 25 ++++++++++++------------- > scripts/qapi-types.py | 32 ++++++++++++++------------------ > scripts/qapi-visit.py | 34 +++++++++++++++------------------- > scripts/qapi.py | 7 +++++-- > 6 files changed, 75 insertions(+), 89 deletions(-) > > diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py > index 25ac52503a..a861ac52e7 100644 > --- a/scripts/qapi-commands.py > +++ b/scripts/qapi-commands.py > @@ -1,16 +1,17 @@ > -# > -# QAPI command marshaller generator > -# > -# Copyright IBM, Corp. 2011 > -# Copyright (C) 2014-2016 Red Hat, Inc. > -# > -# Authors: > -# Anthony Liguori <aliguori@us.ibm.com> > -# Michael Roth <mdroth@linux.vnet.ibm.com> > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > -# See the COPYING file in the top-level directory. > +""" > +QAPI command marshaller generator > + > +Copyright IBM, Corp. 2011 > +Copyright (C) 2014-2018 Red Hat, Inc. > + > +Authors: > + Anthony Liguori <aliguori@us.ibm.com> > + Michael Roth <mdroth@linux.vnet.ibm.com> > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > +See the COPYING file in the top-level directory. > +""" > > from qapi import * > > @@ -257,16 +258,11 @@ class QAPISchemaGenCommandVisitor(QAPISchemaVisitor): > > blurb = ''' > * Schema-defined QAPI/QMP commands > - * > - * Copyright IBM, Corp. 2011 > - * > - * Authors: > - * Anthony Liguori <aliguori@us.ibm.com> > ''' > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qmp-marshal.c', 'qmp-commands.h', > - blurb) > + blurb, __doc__) > > fdef.write(mcgen(''' > > diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py > index 31faedc689..b1d611c5ea 100644 > --- a/scripts/qapi-event.py > +++ b/scripts/qapi-event.py > @@ -1,15 +1,16 @@ > -# > -# QAPI event generator > -# > -# Copyright (c) 2014 Wenchao Xia > -# Copyright (c) 2015-2016 Red Hat Inc. > -# > -# Authors: > -# Wenchao Xia <wenchaoqemu@gmail.com> > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > -# See the COPYING file in the top-level directory. > +""" > +QAPI event generator > + > +Copyright (c) 2014 Wenchao Xia > +Copyright (c) 2015-2018 Red Hat Inc. > + > +Authors: > + Wenchao Xia <wenchaoqemu@gmail.com> > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > +See the COPYING file in the top-level directory. > +""" > > from qapi import * > > @@ -173,16 +174,11 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor): > > blurb = ''' > * Schema-defined QAPI/QMP events > - * > - * Copyright (c) 2014 Wenchao Xia > - * > - * Authors: > - * Wenchao Xia <wenchaoqemu@gmail.com> > ''' > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qapi-event.c', 'qapi-event.h', > - blurb) > + blurb, __doc__) > > fdef.write(mcgen(''' > #include "qemu/osdep.h" > diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py > index 83da2bdb94..bd9253a172 100644 > --- a/scripts/qapi-introspect.py > +++ b/scripts/qapi-introspect.py > @@ -1,13 +1,14 @@ > -# > -# QAPI introspection generator > -# > -# Copyright (C) 2015-2016 Red Hat, Inc. > -# > -# Authors: > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > -# See the COPYING file in the top-level directory. > +""" > +QAPI introspection generator > + > +Copyright (C) 2015-2018 Red Hat, Inc. > + > +Authors: > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > +See the COPYING file in the top-level directory. > +""" > > from qapi import * > > @@ -178,13 +179,11 @@ for o, a in opts: > > blurb = ''' > * QAPI/QMP schema introspection > - * > - * Copyright (C) 2015 Red Hat, Inc. > ''' > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qmp-introspect.c', 'qmp-introspect.h', > - blurb) > + blurb, __doc__) > > fdef.write(mcgen(''' > #include "qemu/osdep.h" > diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py > index 86afc57f92..1103dbda2d 100644 > --- a/scripts/qapi-types.py > +++ b/scripts/qapi-types.py > @@ -1,15 +1,17 @@ > -# > -# QAPI types generator > -# > -# Copyright IBM, Corp. 2011 > -# Copyright (c) 2013-2016 Red Hat Inc. > -# > -# Authors: > -# Anthony Liguori <aliguori@us.ibm.com> > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > +""" > +QAPI types generator > + > +Copyright IBM, Corp. 2011 > +Copyright (c) 2013-2018 Red Hat Inc. > + > +Authors: > + Anthony Liguori <aliguori@us.ibm.com> > + Michael Roth <mdroth@linux.vnet.ibm.com> > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > # See the COPYING file in the top-level directory. > +""" > > from qapi import * > > @@ -252,17 +254,11 @@ for o, a in opts: > > blurb = ''' > * Schema-defined QAPI types > - * > - * Copyright IBM, Corp. 2011 > - * > - * Authors: > - * Anthony Liguori <aliguori@us.ibm.com> > - * Michael Roth <mdroth@linux.vnet.ibm.com> > ''' > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qapi-types.c', 'qapi-types.h', > - blurb) > + blurb, __doc__) > > fdef.write(mcgen(''' > #include "qemu/osdep.h" > diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py > index 9f7127e548..5231f89c36 100644 > --- a/scripts/qapi-visit.py > +++ b/scripts/qapi-visit.py > @@ -1,16 +1,17 @@ > -# > -# QAPI visitor generator > -# > -# Copyright IBM, Corp. 2011 > -# Copyright (C) 2014-2016 Red Hat, Inc. > -# > -# Authors: > -# Anthony Liguori <aliguori@us.ibm.com> > -# Michael Roth <mdroth@linux.vnet.ibm.com> > -# Markus Armbruster <armbru@redhat.com> > -# > -# This work is licensed under the terms of the GNU GPL, version 2. > -# See the COPYING file in the top-level directory. > +""" > +QAPI visitor generator > + > +Copyright IBM, Corp. 2011 > +Copyright (C) 2014-2018 Red Hat, Inc. > + > +Authors: > + Anthony Liguori <aliguori@us.ibm.com> > + Michael Roth <mdroth@linux.vnet.ibm.com> > + Markus Armbruster <armbru@redhat.com> > + > +This work is licensed under the terms of the GNU GPL, version 2. > +See the COPYING file in the top-level directory. > +""" > > from qapi import * > > @@ -336,16 +337,11 @@ for o, a in opts: > > blurb = ''' > * Schema-defined QAPI visitors > - * > - * Copyright IBM, Corp. 2011 > - * > - * Authors: > - * Anthony Liguori <aliguori@us.ibm.com> > ''' > > (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, > 'qapi-visit.c', 'qapi-visit.h', > - blurb) > + blurb, __doc__) > > fdef.write(mcgen(''' > #include "qemu/osdep.h" > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 2e4b2bc9eb..d0816f7479 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -1975,21 +1975,24 @@ def parse_command_line(extra_options='', extra_long_options=[]): > # > > > -def open_output(output_dir, do_c, do_h, prefix, c_file, h_file, blurb): > +def open_output(output_dir, do_c, do_h, prefix, c_file, h_file, blurb, doc): > guard = guardname(prefix + h_file) > c_file = output_dir + prefix + c_file > h_file = output_dir + prefix + h_file > + copyright = '\n * '.join(re.findall(r'^Copyright .*', doc, re.MULTILINE)) > comment = mcgen('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */ > > /* > %(blurb)s > * > + * %(copyright)s > + * > * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. > * See the COPYING.LIB file in the top-level directory. > */ > > ''', > - blurb=blurb.strip('\n')) > + blurb=blurb.strip('\n'), copyright=copyright) > > if output_dir: > try: > -- > 2.13.6 >
Marc-Andre Lureau <mlureau@redhat.com> writes: > Hi > > On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <armbru@redhat.com> wrote: >> Each generator carries a copyright notice for the generator itself, >> and another one for the files it generates. Only the former have been >> updated along the way, the latter have not, and are all out of date. >> >> Fix by copying the generator's copyright notice to the generated files >> instead. > > That makes sense, but we loose the Author lines in the generated > files. Not a big deal I guess, but worth to point out, no? We do. They've become just as outdated as the copyright notices. Giving them the same treatment doesn't seem to be worth the trouble. I'm happy to explain this in the commit message. >> >> Signed-off-by: Markus Armbruster <armbru@redhat.com> > > Other than that, > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Thanks!
On 02/05/2018 07:44 AM, Marc-Andre Lureau wrote: > Hi > > On Fri, Feb 2, 2018 at 2:03 PM, Markus Armbruster <armbru@redhat.com> wrote: >> Each generator carries a copyright notice for the generator itself, >> and another one for the files it generates. Only the former have been >> updated along the way, the latter have not, and are all out of date. >> >> Fix by copying the generator's copyright notice to the generated files >> instead. > > That makes sense, but we loose the Author lines in the generated > files. Not a big deal I guess, but worth to point out, no? I don't see too much use for author lines as long as you have a 'this file is generated' line; you can use git history to learn the authors of the generator code. But yeah, a commit message blurb can't hurt.
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 25ac52503a..a861ac52e7 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-commands.py @@ -1,16 +1,17 @@ -# -# QAPI command marshaller generator -# -# Copyright IBM, Corp. 2011 -# Copyright (C) 2014-2016 Red Hat, Inc. -# -# Authors: -# Anthony Liguori <aliguori@us.ibm.com> -# Michael Roth <mdroth@linux.vnet.ibm.com> -# Markus Armbruster <armbru@redhat.com> -# -# This work is licensed under the terms of the GNU GPL, version 2. -# See the COPYING file in the top-level directory. +""" +QAPI command marshaller generator + +Copyright IBM, Corp. 2011 +Copyright (C) 2014-2018 Red Hat, Inc. + +Authors: + Anthony Liguori <aliguori@us.ibm.com> + Michael Roth <mdroth@linux.vnet.ibm.com> + Markus Armbruster <armbru@redhat.com> + +This work is licensed under the terms of the GNU GPL, version 2. +See the COPYING file in the top-level directory. +""" from qapi import * @@ -257,16 +258,11 @@ class QAPISchemaGenCommandVisitor(QAPISchemaVisitor): blurb = ''' * Schema-defined QAPI/QMP commands - * - * Copyright IBM, Corp. 2011 - * - * Authors: - * Anthony Liguori <aliguori@us.ibm.com> ''' (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, 'qmp-marshal.c', 'qmp-commands.h', - blurb) + blurb, __doc__) fdef.write(mcgen(''' diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py index 31faedc689..b1d611c5ea 100644 --- a/scripts/qapi-event.py +++ b/scripts/qapi-event.py @@ -1,15 +1,16 @@ -# -# QAPI event generator -# -# Copyright (c) 2014 Wenchao Xia -# Copyright (c) 2015-2016 Red Hat Inc. -# -# Authors: -# Wenchao Xia <wenchaoqemu@gmail.com> -# Markus Armbruster <armbru@redhat.com> -# -# This work is licensed under the terms of the GNU GPL, version 2. -# See the COPYING file in the top-level directory. +""" +QAPI event generator + +Copyright (c) 2014 Wenchao Xia +Copyright (c) 2015-2018 Red Hat Inc. + +Authors: + Wenchao Xia <wenchaoqemu@gmail.com> + Markus Armbruster <armbru@redhat.com> + +This work is licensed under the terms of the GNU GPL, version 2. +See the COPYING file in the top-level directory. +""" from qapi import * @@ -173,16 +174,11 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor): blurb = ''' * Schema-defined QAPI/QMP events - * - * Copyright (c) 2014 Wenchao Xia - * - * Authors: - * Wenchao Xia <wenchaoqemu@gmail.com> ''' (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, 'qapi-event.c', 'qapi-event.h', - blurb) + blurb, __doc__) fdef.write(mcgen(''' #include "qemu/osdep.h" diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py index 83da2bdb94..bd9253a172 100644 --- a/scripts/qapi-introspect.py +++ b/scripts/qapi-introspect.py @@ -1,13 +1,14 @@ -# -# QAPI introspection generator -# -# Copyright (C) 2015-2016 Red Hat, Inc. -# -# Authors: -# Markus Armbruster <armbru@redhat.com> -# -# This work is licensed under the terms of the GNU GPL, version 2. -# See the COPYING file in the top-level directory. +""" +QAPI introspection generator + +Copyright (C) 2015-2018 Red Hat, Inc. + +Authors: + Markus Armbruster <armbru@redhat.com> + +This work is licensed under the terms of the GNU GPL, version 2. +See the COPYING file in the top-level directory. +""" from qapi import * @@ -178,13 +179,11 @@ for o, a in opts: blurb = ''' * QAPI/QMP schema introspection - * - * Copyright (C) 2015 Red Hat, Inc. ''' (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, 'qmp-introspect.c', 'qmp-introspect.h', - blurb) + blurb, __doc__) fdef.write(mcgen(''' #include "qemu/osdep.h" diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 86afc57f92..1103dbda2d 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -1,15 +1,17 @@ -# -# QAPI types generator -# -# Copyright IBM, Corp. 2011 -# Copyright (c) 2013-2016 Red Hat Inc. -# -# Authors: -# Anthony Liguori <aliguori@us.ibm.com> -# Markus Armbruster <armbru@redhat.com> -# -# This work is licensed under the terms of the GNU GPL, version 2. +""" +QAPI types generator + +Copyright IBM, Corp. 2011 +Copyright (c) 2013-2018 Red Hat Inc. + +Authors: + Anthony Liguori <aliguori@us.ibm.com> + Michael Roth <mdroth@linux.vnet.ibm.com> + Markus Armbruster <armbru@redhat.com> + +This work is licensed under the terms of the GNU GPL, version 2. # See the COPYING file in the top-level directory. +""" from qapi import * @@ -252,17 +254,11 @@ for o, a in opts: blurb = ''' * Schema-defined QAPI types - * - * Copyright IBM, Corp. 2011 - * - * Authors: - * Anthony Liguori <aliguori@us.ibm.com> - * Michael Roth <mdroth@linux.vnet.ibm.com> ''' (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, 'qapi-types.c', 'qapi-types.h', - blurb) + blurb, __doc__) fdef.write(mcgen(''' #include "qemu/osdep.h" diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 9f7127e548..5231f89c36 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -1,16 +1,17 @@ -# -# QAPI visitor generator -# -# Copyright IBM, Corp. 2011 -# Copyright (C) 2014-2016 Red Hat, Inc. -# -# Authors: -# Anthony Liguori <aliguori@us.ibm.com> -# Michael Roth <mdroth@linux.vnet.ibm.com> -# Markus Armbruster <armbru@redhat.com> -# -# This work is licensed under the terms of the GNU GPL, version 2. -# See the COPYING file in the top-level directory. +""" +QAPI visitor generator + +Copyright IBM, Corp. 2011 +Copyright (C) 2014-2018 Red Hat, Inc. + +Authors: + Anthony Liguori <aliguori@us.ibm.com> + Michael Roth <mdroth@linux.vnet.ibm.com> + Markus Armbruster <armbru@redhat.com> + +This work is licensed under the terms of the GNU GPL, version 2. +See the COPYING file in the top-level directory. +""" from qapi import * @@ -336,16 +337,11 @@ for o, a in opts: blurb = ''' * Schema-defined QAPI visitors - * - * Copyright IBM, Corp. 2011 - * - * Authors: - * Anthony Liguori <aliguori@us.ibm.com> ''' (fdef, fdecl) = open_output(output_dir, do_c, do_h, prefix, 'qapi-visit.c', 'qapi-visit.h', - blurb) + blurb, __doc__) fdef.write(mcgen(''' #include "qemu/osdep.h" diff --git a/scripts/qapi.py b/scripts/qapi.py index 2e4b2bc9eb..d0816f7479 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1975,21 +1975,24 @@ def parse_command_line(extra_options='', extra_long_options=[]): # -def open_output(output_dir, do_c, do_h, prefix, c_file, h_file, blurb): +def open_output(output_dir, do_c, do_h, prefix, c_file, h_file, blurb, doc): guard = guardname(prefix + h_file) c_file = output_dir + prefix + c_file h_file = output_dir + prefix + h_file + copyright = '\n * '.join(re.findall(r'^Copyright .*', doc, re.MULTILINE)) comment = mcgen('''/* AUTOMATICALLY GENERATED, DO NOT MODIFY */ /* %(blurb)s * + * %(copyright)s + * * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. * See the COPYING.LIB file in the top-level directory. */ ''', - blurb=blurb.strip('\n')) + blurb=blurb.strip('\n'), copyright=copyright) if output_dir: try:
Each generator carries a copyright notice for the generator itself, and another one for the files it generates. Only the former have been updated along the way, the latter have not, and are all out of date. Fix by copying the generator's copyright notice to the generated files instead. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- scripts/qapi-commands.py | 34 +++++++++++++++------------------- scripts/qapi-event.py | 32 ++++++++++++++------------------ scripts/qapi-introspect.py | 25 ++++++++++++------------- scripts/qapi-types.py | 32 ++++++++++++++------------------ scripts/qapi-visit.py | 34 +++++++++++++++------------------- scripts/qapi.py | 7 +++++-- 6 files changed, 75 insertions(+), 89 deletions(-)