diff mbox series

[testsuite] : Remove statements with to effect from two fortran testcases

Message ID CAFULd4bBoV5t3-4VzY9bJKzj8S88i9j9c1hx64kRzPBYqz5NzA@mail.gmail.com
State New
Headers show
Series [testsuite] : Remove statements with to effect from two fortran testcases | expand

Commit Message

Uros Bizjak Feb. 2, 2018, 10:32 a.m. UTC
Hello!

Attached patch removes two statements with no effect. These two
statements operate with uninitalized variables, and - depending on the
uninitialized value - can cause denormal FP exceptions when compiled
with -O0. The exception causes runtime failure on the target that
requires -mieee for full IEEE support, e.g. alpha.

The patch removes these statements.

2017-02-02  Uros Bizjak  <ubizjak@gmail.com>

    * gfortran.dg/dec_parameter_1.f (sub1): Remove statement with no effect.
    * gfortran.dg/dec_parameter_2.f90 (sub1): Ditto.

Tested on alphaev68-linux-gnu.

OK for mainline and backports?

Uros.

Comments

Paul Richard Thomas Feb. 2, 2018, 12:23 p.m. UTC | #1
Hi Uros,

This is an easy one to OK :-) Backport it as far back as your patience allows.

Thanks

Paul


On 2 February 2018 at 10:32, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
> Attached patch removes two statements with no effect. These two
> statements operate with uninitalized variables, and - depending on the
> uninitialized value - can cause denormal FP exceptions when compiled
> with -O0. The exception causes runtime failure on the target that
> requires -mieee for full IEEE support, e.g. alpha.
>
> The patch removes these statements.
>
> 2017-02-02  Uros Bizjak  <ubizjak@gmail.com>
>
>     * gfortran.dg/dec_parameter_1.f (sub1): Remove statement with no effect.
>     * gfortran.dg/dec_parameter_2.f90 (sub1): Ditto.
>
> Tested on alphaev68-linux-gnu.
>
> OK for mainline and backports?
>
> Uros.
diff mbox series

Patch

diff --git a/gcc/testsuite/gfortran.dg/dec_parameter_1.f b/gcc/testsuite/gfortran.dg/dec_parameter_1.f
index 69ffa53c806..62e635f4ce8 100644
--- a/gcc/testsuite/gfortran.dg/dec_parameter_1.f
+++ b/gcc/testsuite/gfortran.dg/dec_parameter_1.f
@@ -22,7 +22,6 @@ 
           two = 2.0d0
           x = two * pi_1 * f_1 * t
           y = two * pi_2 * f_2 * t
-          z = two * pi_3 * f_3 * t
           return
         end subroutine
 
diff --git a/gcc/testsuite/gfortran.dg/dec_parameter_2.f90 b/gcc/testsuite/gfortran.dg/dec_parameter_2.f90
index 280f0007f93..d0c9f8b7eb0 100644
--- a/gcc/testsuite/gfortran.dg/dec_parameter_2.f90
+++ b/gcc/testsuite/gfortran.dg/dec_parameter_2.f90
@@ -21,7 +21,6 @@  subroutine sub1(t, x, y)
   two = 2.0d0
   x = two * pi_1 * f_1 * t
   y = two * pi_2 * f_2 * t
-  z = two * pi_3 * f_3 * t
   return
 end subroutine