[SRU,Xenial,Artful,1/1] libata: apply MAX_SEC_1024 to all LITEON EP1 series devices

Message ID 2c6c4908ff3fe1292e23ab1998491e47adab7183.1517512048.git.joseph.salisbury@canonical.com
State New
Headers show
Series
  • libata: apply MAX_SEC_1024 to all LITEON EP1 series devices
Related show

Commit Message

Joseph Salisbury Feb. 1, 2018, 7:16 p.m.
From: Xinyu Lin <xinyu0123@gmail.com>

BugLink: http://bugs.launchpad.net/bugs/lp1743053

LITEON EP1 has the same timeout issues as CX1 series devices.

Revert max_sectors to the value of 1024.

'e0edc8c54646 ("libata: apply MAX_SEC_1024 to all CX1-JB*-HP devices")'

Signed-off-by: Xinyu Lin <xinyu0123@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
(cherry picked from commit db5ff909798ef0099004ad50a0ff5fde92426fd1)
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
---
 drivers/ata/libata-core.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kleber Souza Feb. 6, 2018, 4:11 p.m. | #1
On 02/01/18 20:16, Joseph Salisbury wrote:
> From: Xinyu Lin <xinyu0123@gmail.com>
> 
> BugLink: http://bugs.launchpad.net/bugs/lp1743053

The correct link is http://bugs.launchpad.net/bugs/1743053. This can be
fixed when applying the patch, no need to resubmit.

> 
> LITEON EP1 has the same timeout issues as CX1 series devices.
> 
> Revert max_sectors to the value of 1024.
> 
> 'e0edc8c54646 ("libata: apply MAX_SEC_1024 to all CX1-JB*-HP devices")'
> 
> Signed-off-by: Xinyu Lin <xinyu0123@gmail.com>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: stable@vger.kernel.org
> (cherry picked from commit db5ff909798ef0099004ad50a0ff5fde92426fd1)
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>

Clean cherry-pick, good test results and fixes a regression. It's also
now applied on linux-4.4.y for 4.4.113.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  drivers/ata/libata-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index b0b77b6..69ec1c5 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4143,6 +4143,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	 * https://bugzilla.kernel.org/show_bug.cgi?id=121671
>  	 */
>  	{ "LITEON CX1-JB*-HP",	NULL,		ATA_HORKAGE_MAX_SEC_1024 },
> +	{ "LITEON EP1-*",	NULL,		ATA_HORKAGE_MAX_SEC_1024 },
>  
>  	/* Devices we expect to fail diagnostics */
>  
>

Patch

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b0b77b6..69ec1c5 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4143,6 +4143,7 @@  static const struct ata_blacklist_entry ata_device_blacklist [] = {
 	 * https://bugzilla.kernel.org/show_bug.cgi?id=121671
 	 */
 	{ "LITEON CX1-JB*-HP",	NULL,		ATA_HORKAGE_MAX_SEC_1024 },
+	{ "LITEON EP1-*",	NULL,		ATA_HORKAGE_MAX_SEC_1024 },
 
 	/* Devices we expect to fail diagnostics */