| Message ID | 20180201173307.29877-1-abrodkin@synopsys.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [U-Boot] board_f: Show only .text location in display_text_info() | expand |
Hi Alexey, On 1 February 2018 at 10:33, Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote: > > For some reason we used to print not only location of .text > section [before relocation] but also .bss start and end. > > Moreover how that was printed was obviously misleading: > --------------------------------->8--------------------------- > U-Boot code: 20001000 -> 30008C00 BSS: -> 3000C58E > --------------------------------->8--------------------------- > > I would interpret it like this: > U-Boot's code is situated in memory starting from 0x20001000 > till 0x30008000.. and BTW there's .bss section starting from 0x3000C58E. > > Which is wrong. But anyways why bother about .bss here so let's > drop .bss part in that pure debug output. > > Note even though this change has logically nothing in common with [1] > they both touch the same function display_text_info() which makes [1] > a prerequisite for this one. Otherwise trivial modifications will be > required in both if they happen to be reordered. > > [1] http://patchwork.ozlabs.org/patch/868299/ > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > --- > common/board_f.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) I think it is sometimes useful to print BSS. I have had problems with it overlapping (e.g.) the DT. Can you just fix the output? Regards, Simon
diff --git a/common/board_f.c b/common/board_f.c index de3907cd11fc..cfb4cfc52133 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -124,15 +124,7 @@ static int init_baud_rate(void) static int display_text_info(void) { #if !defined(CONFIG_SANDBOX) && !defined(CONFIG_EFI_APP) - ulong bss_start, bss_end, text_base; - - bss_start = (ulong)&__bss_start; - bss_end = (ulong)&__bss_end; - - text_base = CONFIG_SYS_TEXT_BASE; - - debug("U-Boot code: %08lX -> %08lX BSS: -> %08lX\n", - text_base, bss_start, bss_end); + debug("U-Boot code: %08x\n", CONFIG_SYS_TEXT_BASE); #endif return 0;
For some reason we used to print not only location of .text section [before relocation] but also .bss start and end. Moreover how that was printed was obviously misleading: --------------------------------->8--------------------------- U-Boot code: 20001000 -> 30008C00 BSS: -> 3000C58E --------------------------------->8--------------------------- I would interpret it like this: U-Boot's code is situated in memory starting from 0x20001000 till 0x30008000.. and BTW there's .bss section starting from 0x3000C58E. Which is wrong. But anyways why bother about .bss here so let's drop .bss part in that pure debug output. Note even though this change has logically nothing in common with [1] they both touch the same function display_text_info() which makes [1] a prerequisite for this one. Otherwise trivial modifications will be required in both if they happen to be reordered. [1] http://patchwork.ozlabs.org/patch/868299/ Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> --- common/board_f.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)