diff mbox series

lan78xx: remove redundant initialization of pointer 'phydev'

Message ID 20180201171018.22267-1-colin.king@canonical.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series lan78xx: remove redundant initialization of pointer 'phydev' | expand

Commit Message

Colin Ian King Feb. 1, 2018, 5:10 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Pointer phydev is initialized and this value is never read, phydev
is immediately updated to a new value, hence this initialization
is redundant and can be removed

Cleans up clang warning:
drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/usb/lan78xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Feb. 1, 2018, 7:54 p.m. UTC | #1 
From: Colin King <colin.king@canonical.com>
Date: Thu,  1 Feb 2018 17:10:18 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> Pointer phydev is initialized and this value is never read, phydev
> is immediately updated to a new value, hence this initialization
> is redundant and can be removed
> 
> Cleans up clang warning:
> drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index ec56ff29aac4..60a604cc7647 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -2006,7 +2006,7 @@  static int lan78xx_phy_init(struct lan78xx_net *dev)
 {
 	int ret;
 	u32 mii_adv;
-	struct phy_device *phydev = dev->net->phydev;
+	struct phy_device *phydev;
 
 	phydev = phy_find_first(dev->mdiobus);
 	if (!phydev) {