Patchwork [7/7] tcp_cubic: fix low utilization of CUBIC with HyStart

login
register
mail settings
Submitter stephen hemminger
Date March 14, 2011, 5:52 p.m.
Message ID <20110314175439.844558845@vyatta.com>
Download mbox | patch
Permalink /patch/86791/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - March 14, 2011, 5:52 p.m.
From: Sangtae Ha <sangtae.ha@gmail.com>

HyStart sets the initial exit point of slow start.
Suppose that HyStart exits at 0.5BDP in a BDP network and no history exists.
If the BDP of a network is large, CUBIC's initial cwnd growth may be
too conservative to utilize the link.
CUBIC increases the cwnd 20% per RTT in this case.

Signed-off-by: Sangtae Ha <sangtae.ha@gmail.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
---
 net/ipv4/tcp_cubic.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/net/ipv4/tcp_cubic.c	2011-03-14 08:32:46.347993869 -0700
+++ b/net/ipv4/tcp_cubic.c	2011-03-14 10:57:00.846549449 -0700
@@ -270,6 +270,13 @@  static inline void bictcp_update(struct
 		ca->cnt = 100 * cwnd;              /* very small increment*/
 	}
 
+	/*
+	 * The initial growth of cubic function may be too conservative
+	 * when the available bandwidth is still unknown.
+	 */
+	if (ca->loss_cwnd == 0 && ca->cnt > 20)
+		ca->cnt = 20;	/* increase cwnd 5% per RTT */
+
 	/* TCP Friendly */
 	if (tcp_friendliness) {
 		u32 scale = beta_scale;