diff mbox series

lib: fwts_acpi_tables: remove redundant initialization to 'result'

Message ID 20180131102813.28753-1-colin.king@canonical.com
State Accepted
Headers show
Series lib: fwts_acpi_tables: remove redundant initialization to 'result' | expand

Commit Message

Colin Ian King Jan. 31, 2018, 10:28 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Variable 'result' is going to be over-written later, so there is no
need to initialize it, remove the redundant initialization.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alex Hung Feb. 2, 2018, 2:49 a.m. UTC | #1 
On 2018-01-31 02:28 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable 'result' is going to be over-written later, so there is no
> need to initialize it, remove the redundant initialization.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index c966edd6..2aa30f80 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -378,7 +378,7 @@ static int fwts_acpi_handle_fadt(
>   	const fwts_acpi_table_provenance provenance)
>   {
>   	static uint64_t	facs_last_phys_addr;	/* default to zero */
> -	int result = FWTS_ERROR;
> +	int result;
>   
>   	/*
>   	 *  The FADT handling may occur twice if it appears
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Feb. 6, 2018, 3:03 a.m. UTC | #2 
On 01/31/2018 06:28 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable 'result' is going to be over-written later, so there is no
> need to initialize it, remove the redundant initialization.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_acpi_tables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index c966edd6..2aa30f80 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -378,7 +378,7 @@ static int fwts_acpi_handle_fadt(
>  	const fwts_acpi_table_provenance provenance)
>  {
>  	static uint64_t	facs_last_phys_addr;	/* default to zero */
> -	int result = FWTS_ERROR;
> +	int result;
>  
>  	/*
>  	 *  The FADT handling may occur twice if it appears
Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
index c966edd6..2aa30f80 100644
--- a/src/lib/src/fwts_acpi_tables.c
+++ b/src/lib/src/fwts_acpi_tables.c
@@ -378,7 +378,7 @@  static int fwts_acpi_handle_fadt(
 	const fwts_acpi_table_provenance provenance)
 {
 	static uint64_t	facs_last_phys_addr;	/* default to zero */
-	int result = FWTS_ERROR;
+	int result;
 
 	/*
 	 *  The FADT handling may occur twice if it appears