| Message ID | 20180131023947.24832-2-joel@jms.id.au |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Add missing bt nodes | expand |
On Wed, Jan 31, 2018 at 1:09 PM, Joel Stanley <joel@jms.id.au> wrote: > The IPMI BT device part of the LPC interface and is used for > communication with the host processor. > > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > v2: > Fix bt reg node. It should be an offset from the lpc_host address, > not the actual address of the iBT > > arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++ > arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++ > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi > index e6f4047142a8..7e0da0b8cd12 100644 > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > @@ -246,6 +246,13 @@ > reg = <0x20 0x24 0x48 0x8>; > }; > > + ibt: ibt@140 { > + compatible = "aspeed,ast2400-ibt-bmc"; > + reg = <0xc0 0x18>; > + interrupts = <8>; > + status = "disabled"; > + }; > + > mbox: mbox@180 { > compatible = "aspeed,ast2400-mbox"; > reg = <0x180 0x5c>; > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi > index b7b42c7c89e1..f1b2fa204873 100644 > --- a/arch/arm/boot/dts/aspeed-g5.dtsi > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi > @@ -299,6 +299,13 @@ > reg = <0x20 0x24 0x48 0x8>; > }; > > + ibt: ibt@140 { I forgot to update the node name. > + compatible = "aspeed,ast2500-ibt-bmc"; > + reg = <0xc0 0x18>; > + interrupts = <8>; > + status = "disabled"; > + }; > + > mbox: mbox@180 { > compatible = "aspeed,ast2500-mbox"; > reg = <0x180 0x5c>; > -- > 2.15.1 >
On Wed, Jan 31, 2018 at 1:24 PM, Joel Stanley <joel@jms.id.au> wrote: > On Wed, Jan 31, 2018 at 1:09 PM, Joel Stanley <joel@jms.id.au> wrote: >> The IPMI BT device part of the LPC interface and is used for >> communication with the host processor. >> >> Signed-off-by: Joel Stanley <joel@jms.id.au> >> --- >> v2: >> Fix bt reg node. It should be an offset from the lpc_host address, >> not the actual address of the iBT >> >> arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++ >> arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi >> index e6f4047142a8..7e0da0b8cd12 100644 >> --- a/arch/arm/boot/dts/aspeed-g4.dtsi >> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi >> @@ -246,6 +246,13 @@ >> reg = <0x20 0x24 0x48 0x8>; >> }; >> >> + ibt: ibt@140 { >> + compatible = "aspeed,ast2400-ibt-bmc"; >> + reg = <0xc0 0x18>; >> + interrupts = <8>; >> + status = "disabled"; >> + }; >> + >> mbox: mbox@180 { >> compatible = "aspeed,ast2400-mbox"; >> reg = <0x180 0x5c>; >> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi >> index b7b42c7c89e1..f1b2fa204873 100644 >> --- a/arch/arm/boot/dts/aspeed-g5.dtsi >> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi >> @@ -299,6 +299,13 @@ >> reg = <0x20 0x24 0x48 0x8>; >> }; >> >> + ibt: ibt@140 { > > I forgot to update the node name. Andrew did an over the shoulder review of this patch. He said that with the node name fixed: Acked-by: Andrew Jeffery <andrew@aj.id.au>
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi index e6f4047142a8..7e0da0b8cd12 100644 --- a/arch/arm/boot/dts/aspeed-g4.dtsi +++ b/arch/arm/boot/dts/aspeed-g4.dtsi @@ -246,6 +246,13 @@ reg = <0x20 0x24 0x48 0x8>; }; + ibt: ibt@140 { + compatible = "aspeed,ast2400-ibt-bmc"; + reg = <0xc0 0x18>; + interrupts = <8>; + status = "disabled"; + }; + mbox: mbox@180 { compatible = "aspeed,ast2400-mbox"; reg = <0x180 0x5c>; diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index b7b42c7c89e1..f1b2fa204873 100644 --- a/arch/arm/boot/dts/aspeed-g5.dtsi +++ b/arch/arm/boot/dts/aspeed-g5.dtsi @@ -299,6 +299,13 @@ reg = <0x20 0x24 0x48 0x8>; }; + ibt: ibt@140 { + compatible = "aspeed,ast2500-ibt-bmc"; + reg = <0xc0 0x18>; + interrupts = <8>; + status = "disabled"; + }; + mbox: mbox@180 { compatible = "aspeed,ast2500-mbox"; reg = <0x180 0x5c>;
The IPMI BT device part of the LPC interface and is used for communication with the host processor. Signed-off-by: Joel Stanley <joel@jms.id.au> --- v2: Fix bt reg node. It should be an offset from the lpc_host address, not the actual address of the iBT arch/arm/boot/dts/aspeed-g4.dtsi | 7 +++++++ arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++ 2 files changed, 14 insertions(+)