Patchwork [v2,2/2] target-arm: use make_float32() to make constant floats for VRSQRTS

login
register
mail settings
Submitter Peter Maydell
Date March 14, 2011, 3:37 p.m.
Message ID <1300117033-27120-3-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/86765/
State New
Headers show

Comments

Peter Maydell - March 14, 2011, 3:37 p.m.
The preferred way to create a constant floating point value is to use
make_float32() rather than doing a runtime int32_to_float32().
Convert the code in the VRSQRTS helper to work this way.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/helper.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

Patch

diff --git a/target-arm/helper.c b/target-arm/helper.c
index c01a5a2..0dd2549 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -2708,6 +2708,8 @@  uint32_t HELPER(vfp_fcvt_f32_to_f16)(float32 a, CPUState *env)
 }
 
 #define float32_two make_float32(0x40000000)
+#define float32_three make_float32(0x40400000)
+#define float32_one_point_five make_float32(0x3fc00000)
 
 float32 HELPER(recps_f32)(float32 a, float32 b, CPUState *env)
 {
@@ -2722,16 +2724,13 @@  float32 HELPER(recps_f32)(float32 a, float32 b, CPUState *env)
 float32 HELPER(rsqrts_f32)(float32 a, float32 b, CPUState *env)
 {
     float_status *s = &env->vfp.standard_fp_status;
-    float32 two = int32_to_float32(2, s);
-    float32 three = int32_to_float32(3, s);
     float32 product;
     if ((float32_is_infinity(a) && float32_is_zero_or_denormal(b)) ||
         (float32_is_infinity(b) && float32_is_zero_or_denormal(a))) {
-        product = float32_zero;
-    } else {
-        product = float32_mul(a, b, s);
+        return float32_one_point_five;
     }
-    return float32_div(float32_sub(three, product, s), two, s);
+    product = float32_mul(a, b, s);
+    return float32_div(float32_sub(float32_three, product, s), float32_two, s);
 }
 
 /* NEON helpers.  */