Message ID | 20180130151144.32544-1-colin.king@canonical.com (mailing list archive) |
---|---|
State | Accepted |
Commit | dedab7f0d3137441a97fe7cf9b9ca5dbd20ca9a5 |
Headers | show |
Series | ocxl: fix signed comparison with less than zero | expand |
On 31/01/18 02:11, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Thanks for picking this up! Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > drivers/misc/ocxl/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c > index c90c1a578d2f..1287e4430e6b 100644 > --- a/drivers/misc/ocxl/file.c > +++ b/drivers/misc/ocxl/file.c > @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, > struct ocxl_context *ctx = file->private_data; > struct ocxl_kernel_event_header header; > ssize_t rc; > - size_t used = 0; > + ssize_t used = 0; > DEFINE_WAIT(event_wait); > > memset(&header, 0, sizeof(header)); >
Le 30/01/2018 à 16:11, Colin King a écrit : > From: Colin Ian King <colin.king@canonical.com> > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- Thanks! Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> > drivers/misc/ocxl/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c > index c90c1a578d2f..1287e4430e6b 100644 > --- a/drivers/misc/ocxl/file.c > +++ b/drivers/misc/ocxl/file.c > @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, > struct ocxl_context *ctx = file->private_data; > struct ocxl_kernel_event_header header; > ssize_t rc; > - size_t used = 0; > + ssize_t used = 0; > DEFINE_WAIT(event_wait); > > memset(&header, 0, sizeof(header)); >
On Tue, 2018-01-30 at 15:11:44 UTC, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the comparison of used < 0 is always false because > uses is a size_t. Fix this by making used a ssize_t type. > > Detected by Coccinelle: > drivers/misc/ocxl/file.c:320:6-10: WARNING: Unsigned expression > compared with zero: used < 0 > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/dedab7f0d3137441a97fe7cf9b9ca5 cheers
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index c90c1a578d2f..1287e4430e6b 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -277,7 +277,7 @@ static ssize_t afu_read(struct file *file, char __user *buf, size_t count, struct ocxl_context *ctx = file->private_data; struct ocxl_kernel_event_header header; ssize_t rc; - size_t used = 0; + ssize_t used = 0; DEFINE_WAIT(event_wait); memset(&header, 0, sizeof(header));