| Message ID | 20180130040720.20172-2-casantos@datacom.ind.br |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] eudev: fix error handling init script | expand |
Hello, On Tue, 30 Jan 2018 02:07:19 -0200, Carlos Santos wrote: > Using a variable in a printf format string may lead to undesirable > results if the variable contains format controls, so replace > > printf "foo $var bar" > > by > > printf "foo %s bar" "$var" > > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> > --- > package/eudev/S10udev | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas
>>>>> "Carlos" == Carlos Santos <casantos@datacom.ind.br> writes: > Using a variable in a printf format string may lead to undesirable > results if the variable contains format controls, so replace > printf "foo $var bar" > by > printf "foo %s bar" "$var" > Signed-off-by: Carlos Santos <casantos@datacom.ind.br> Committed to 2017.02.x and 2017.11.x, thanks.
diff --git a/package/eudev/S10udev b/package/eudev/S10udev index 654a04df36..640fec625b 100755 --- a/package/eudev/S10udev +++ b/package/eudev/S10udev @@ -27,7 +27,7 @@ test -r $UDEV_CONFIG || exit 6 case "$1" in start) - printf "Populating ${udev_root:-/dev} using udev: " + printf "Populating %s using udev: " "${udev_root:-/dev}" printf '\000\000\000\000' > /proc/sys/kernel/hotplug $UDEV_BIN -d || { echo "FAIL"; exit 1; } udevadm trigger --type=subsystems --action=add
Using a variable in a printf format string may lead to undesirable results if the variable contains format controls, so replace printf "foo $var bar" by printf "foo %s bar" "$var" Signed-off-by: Carlos Santos <casantos@datacom.ind.br> --- package/eudev/S10udev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)