Message ID | 20180129160740.1195-1-stefanha@redhat.com |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180129160740.1195-1-stefanha@redhat.com Subject: [Qemu-devel] [PULL 0/3] Tracing patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu fccfcc6328..0d1442912b master -> master t [tag update] patchew/20171130164750.47320-1-vsementsov@virtuozzo.com -> patchew/20171130164750.47320-1-vsementsov@virtuozzo.com * [new tag] patchew/20180129160740.1195-1-stefanha@redhat.com -> patchew/20180129160740.1195-1-stefanha@redhat.com Switched to a new branch 'test' 8224c195a1 tracetool: report error on foo() instead of foo(void) 511aad4f63 tracetool: clarify that "formats" means "format strings" cda21c769c tracetool: prefix parse errors with line numbers === OUTPUT BEGIN === Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... ERROR: line over 90 characters #39: FILE: scripts/tracetool/__init__.py:240: + raise ValueError("Only events with 'tcg' property can have two format strings") WARNING: line over 80 characters #42: FILE: scripts/tracetool/__init__.py:242: + raise ValueError("Events with 'tcg' property must have two format strings") total: 1 errors, 1 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... WARNING: line over 80 characters #26: FILE: scripts/tracetool/__init__.py:79: + raise ValueError("Empty argument (did you forget to use 'void'?)") total: 0 errors, 1 warnings, 8 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On 29 January 2018 at 16:07, Stefan Hajnoczi <stefanha@redhat.com> wrote: > The following changes since commit 6233b4a8c2a32ef6955a921246fa08705bbb3676: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2018-01-26' into staging (2018-01-26 17:29:14 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to 24f4d3d3aeabf83445839099d6d66cbb3089c37a: > > tracetool: report error on foo() instead of foo(void) (2018-01-29 10:34:55 +0000) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Stefan Hajnoczi (3): > tracetool: prefix parse errors with line numbers > tracetool: clarify that "formats" means "format strings" > tracetool: report error on foo() instead of foo(void) > > scripts/tracetool/__init__.py | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) Applied, thanks. -- PMM
On Mon, Jan 29, 2018 at 08:14:46AM -0800, no-reply@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/3: tracetool: prefix parse errors with line numbers... > Checking PATCH 2/3: tracetool: clarify that "formats" means "format strings"... > ERROR: line over 90 characters > #39: FILE: scripts/tracetool/__init__.py:240: > + raise ValueError("Only events with 'tcg' property can have two format strings") > > WARNING: line over 80 characters > #42: FILE: scripts/tracetool/__init__.py:242: > + raise ValueError("Events with 'tcg' property must have two format strings") > > total: 1 errors, 1 warnings, 27 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 3/3: tracetool: report error on foo() instead of foo(void)... > WARNING: line over 80 characters > #26: FILE: scripts/tracetool/__init__.py:79: > + raise ValueError("Empty argument (did you forget to use 'void'?)") > > total: 0 errors, 1 warnings, 8 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === For the record, I didn't wrap these error messages so that grep(1) works. Stefan